Screen: Virtual methods for SDL and window resize events
#3032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `Screen` abstract class now provides virtual methods for SDL and window resize events. The `Editor` and `PartcleEditor` classes now `override` the `event(const SDL_Event& ev)` method and `Editor` `override`s `on_window_resize()`. Resize events in `ScreenManager` are now handled by all `Screen`s in the stack. SDL events are only handled by the current (top) screen. Additionally, `OptionsMenu` now calls `ScreenManager::on_window_resize()` on video setting changes, instead of just calling `MenuManager::on_window_resize()`. This fixes a bug where the editor crashes on changing the "Video Resolution" and "Magnification" settings from the in-editor "Options" menu.
Vankata453
added
category:code
status:needs-review
MatusGuy
reviewed
Aug 5, 2024
MatusGuy
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Screenabstract class now provides virtual methods for SDL and window resize events. TheEditorandParticleEditorclasses nowoverridetheevent(const SDL_Event& ev)method andEditoroverrideson_window_resize().Resize events in
ScreenManagerare now handled by allScreens in the stack. SDL events are only handled by the current (top) screen.Additionally,
OptionsMenunow callsScreenManager::on_window_resize()on video setting changes, instead of just callingMenuManager::on_window_resize(). This fixes a bug where the game crashes on changing the "Video Resolution" and "Magnification" settings from the in-editor "Options" menu.