Feature/fix build deps #28
Open
+18
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Semphriss
requested changes
Apr 25, 2021
There was a problem hiding this comment.
- Some libraries (such as SDL2 and libcurl4 are missing, and the
sudo apt install's are redundant. Please check this line for reference:sudo apt-get update && sudo apt-get install -y cmake build-essential libogg-dev libvorbis-dev libopenal-dev libboost-all-dev libsdl2-dev libsdl2-image-dev libfreetype6-dev libraqm-dev libcurl4-openssl-dev libglew-dev libharfbuzz-dev libfribidi-dev - Please don't make an entire section just for that; put it at the end of the preceeding section instead, with an introduction like "For ease of use, here are some installation lines for some Linux distributions:" and if the line given above works without edit, please specify it works for both Debian and Ubuntu.
|
Thank you for your help and comments. Answers inline.
Thank you for your comments. I will add as one single line as you specified. Also, I don't recommend using
OK, will do so for the section. For specifying it works for Debian and Ubuntu, I don't own an Ubuntu machine and I didn't tested it running in Ubuntu. This is why I didn't mention it. Can I just put a message like: "These were not tested in Ubuntu but they are likely to work."? |
|
Is this good to go? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds instructions about how to install build dependencies in Debian 10 systems. Please, review and make your comments.
Thank you.