Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesigned modifiers #25

Merged
merged 4 commits into from
Jul 19, 2021
Merged

Redesigned modifiers #25

merged 4 commits into from
Jul 19, 2021

Conversation

xgreenx
Copy link
Contributor

@xgreenx xgreenx commented Jul 15, 2021

Instead of copy/pasting the code from the modifier declaration. We will directly call the modifier's function on rust level.
The first argument is an instance of a contract. The second argument is the body code of function marked with a modifier.
Every next argument can be specified by the developer and past inside of the modifier.

Instead of copy/pasting the code from modifier declaration. We will directly call the modifier's function on rust level.
First argument is instance of contract. Second argument is body code of function marked with modifier.
Every next arguments can by specified by developer and past inside of modifier.
Copy link
Contributor

@PierreOssun PierreOssun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work ! Just some tiny suggestions

contracts/brush/proc_macros/lib.rs Outdated Show resolved Hide resolved
contracts/brush/proc_macros/lib.rs Outdated Show resolved Hide resolved
contracts/brush/proc_macros/lib.rs Outdated Show resolved Hide resolved
contracts/brush/proc_macros/lib.rs Outdated Show resolved Hide resolved
contracts/brush/proc_macros/lib.rs Outdated Show resolved Hide resolved
contracts/brush/proc_macros/lib.rs Outdated Show resolved Hide resolved
contracts/brush/proc_macros/lib.rs Outdated Show resolved Hide resolved
contracts/brush/proc_macros/modifiers.rs Outdated Show resolved Hide resolved
contracts/security/reentrancy_guard/traits.rs Outdated Show resolved Hide resolved
@xgreenx xgreenx changed the title Redesigned modifiers. Redesigned modifiers Jul 19, 2021
Copy link
Contributor

@VargSupercolony VargSupercolony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments and suggestions. Other than that ok for me -- great work Green!

contracts/brush/proc_macros/modifier_definition.rs Outdated Show resolved Hide resolved
contracts/brush/proc_macros/modifier_definition.rs Outdated Show resolved Hide resolved
contracts/brush/proc_macros/modifier_definition.rs Outdated Show resolved Hide resolved
contracts/brush/proc_macros/modifiers.rs Outdated Show resolved Hide resolved
contracts/brush/proc_macros/modifiers.rs Outdated Show resolved Hide resolved
contracts/brush/proc_macros/modifiers.rs Outdated Show resolved Hide resolved
@xgreenx xgreenx merged commit 741c8b7 into main Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants