Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

March 15-03-2019 #1

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

shaliniiit
Copy link

Attendance for 15th March 2019.

@shaliniiit
Copy link
Author

Changes made.

@SpandanKumarSahu
Copy link
Contributor

@shaliniiit , it is not a good practice to send a pull request from your master to the master branch of the source repo.
You can undo the commit, by using git reset, then create a separate branch, make the necessary changes in the new branch and then send a pull request to merge your new branch with the source repo's master branch.

If you've any doubts, you can revisit the tutorial on git and github, or I can explain again. This is the first merge on this repository, which is why I wanted to maintain the standard practices, so that from next time everyone can follow the standard procedure.

@shaliniiit
Copy link
Author

shaliniiit commented Mar 17, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants