-
-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependency which relies on ~/.cargo/registry/src
#150
Comments
(duckdb/duckdb-rs#178 for the issue on that repo) |
Thanks a lot @Swatinem ! We'll test it now |
Thanks @Swatinem I was just writing up a comment here, then I noticed you just shipped a change! For future reference to others with large projects. If you have dependencies which themselves have large dependency lists (especially There was a fork made by @bmwill https://github.com/bmwill/rust-cache, which allows you to specify a path to save. Though that one is not maintained and seems like some gh warnings in the deployment may soon become errors. Found it by following the breadcrumbs here: |
This works! Thank you v much @Swatinem . FYI — if interesting — we still get one line stating |
@max-sixty I'm testing this now too. Slightly off topic, have you encountered an issue like this? #155 |
@Swatinem Worked for me! Great stuff! |
Not yet! I eagerly await my meeting with it though... |
Yeah I threw that together a while back in order to fix caching of the |
Ah, unfortunately I spoke too soon, I'm sorry.
Unfortunately while this is true, a few lines later we get I can't seem to reopen — @Swatinem let me know if you'd like to reopen, or I should start a new issue (or that this is the issue of the dependency rather than this repo and we should reopen upstream?) |
I might try myself again at fixing this, I thought keeping the |
This seems like it might be fixed! https://github.com/PRQL/prql/actions/runs/5986134105/job/16238928467 is an example of it not running I couldn't see a commit which fixed this, but I don't have much context. I guess it's possible it's something non-deterministic. Though it seems fairly consistent recently... |
We're reverting our workaround for this: #3449, given it seems to be fixed. I'll close this issue, but feel free to reopen if I'm mistaken (possibly something else changed such that this doesn't affect us any longer...) Thank you! |
Thanks for the excellent GH Action!
duckdb
seems to rely on files in~/.cargo/registry/src
— full context over at PRQL/prql#2870.Would it be possible to optionally disable removing this path? Or offer a glob for disabling some paths from being removed?
This is related to #100 — though in this case, it makes the whole build take almost as much time as without a cache (feel free to close as dupe if it is indeed the same though)
The text was updated successfully, but these errors were encountered: