Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add random to Bool, including a test #272

Merged
merged 1 commit into from
Oct 5, 2017

Conversation

MaxHaertwig
Copy link
Contributor

Checklist

  • I checked the Contributing Guidelines before creating this request.
  • New extensions are written in Swift 4.
  • New extensions support iOS 8.0+ / tvOS 9.0+ / macOS 10.10+ / watchOS 2.0+.
  • I have added tests for new extensions, and they passed.
  • All extensions have a clear comments explaining their functionality, all parameters and return type in English.
  • All extensions are declared as public.

I'm not quite sure about the test, but the chance that it fails should be sufficiently small.

@SwifterSwiftBot
Copy link

2 Warnings
⚠️ Consider adding tests for new extensions or updating existing tests for a modified SwifterSwift extension
⚠️ The source files have been modified. Please consider adding a CHANGELOG entry if necessary.
1 Message
📖 Thank you for submitting a pull request to SwifterSwift. The team will review your submission as soon as possible.

Generated by 🚫 Danger

@codecov
Copy link

codecov bot commented Oct 4, 2017

Codecov Report

Merging #272 into master will increase coverage by 0.1%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #272     +/-   ##
=========================================
+ Coverage   54.86%   54.96%   +0.1%     
=========================================
  Files          46       46             
  Lines        3292     3300      +8     
=========================================
+ Hits         1806     1814      +8     
  Misses       1486     1486
Impacted Files Coverage Δ
Tests/SwiftStdlibTests/BoolExtensionsTests.swift 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15fc96f...8b1c183. Read the comment docs.

@omaralbeik omaralbeik self-assigned this Oct 5, 2017
@omaralbeik omaralbeik merged commit a7f31b2 into SwifterSwift:master Oct 5, 2017

func testRandom() {
var yes = 0, no = 0
for _ in 1...10000 {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to not do this 10,000 times 😱 Just making note of it

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SD10 I agree, 10 times is enough, will update it soon

@MaxHaertwig MaxHaertwig deleted the bool-random branch October 5, 2017 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants