Add isValidIndexPath to UITableViewExtensions #441
Conversation
Generated by 🚫 Danger |
Codecov Report
@@ Coverage Diff @@
## master #441 +/- ##
==========================================
+ Coverage 91.63% 91.63% +<.01%
==========================================
Files 58 58
Lines 2677 2679 +2
==========================================
+ Hits 2453 2455 +2
Misses 224 224
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Thank you for your contribution @setoelkahfi :)
Could you please add a changelog entry describing your new extension, more info here.
|
Will do @omaralbeik |
| @@ -4,6 +4,8 @@ The changelog for **SwifterSwift**. Also see the [releases](https://github.com/S | |||
| > # Upcoming release | |||
| > | |||
| > ### Added | |||
| - **UITableViewExtentions**: | |||
| - Added `isValidIndexPath(_ indexPath:)` method to check whether given IndexPath is valid within UITableView. [#441](https://github.com/SwifterSwift/SwifterSwift/pull/441) by [setoelkahfi](https://github.com/setoelkahfi). | |||
| > ### Changed | |||
| - **UITableViewExtentions**: | |||
There was a problem hiding this comment.
@setoelkahfi, could you please add your changes here, we don't have to create a new UITableViewExtentions title if it already exists
There was a problem hiding this comment.
Oh, so it should be in the 'Changed' section of UITableViewExtentions, @omaralbeik ?
There was a problem hiding this comment.
Oops, sorry my bad @setoelkahfi I didn't notice it was under changed 😅
|
Thank you for contributing to SwifterSwift! I've invited you to join the SwifterSwift GitHub organization - no pressure to accept! If you'd like more information on what that means, check out our contributing guidelines. Feel free to reach out if you have any questions! 😃 |
🚀
This PR will support my next PR about safely scroll table view to index path. Because it mentioned that one PR only for one extension, so I separate it.
Checklist