fix bug: Rotated UIImage lose origin scale and blured. #904

unknown-undefined · 2020-09-15T08:42:14Z

Fix bug. When UIImage rotated, it lost origin scale.

Checklist

I checked the Contributing Guidelines before creating this request.
New extensions are written in Swift 5.0.
New extensions support iOS 10.0+ / tvOS 9.0+ / macOS 10.10+ / watchOS 2.0+, or use @available if not.
I have added tests for new extensions, and they passed.
All extensions have a clear comments explaining their functionality, all parameters and return type in English.
All extensions are declared as public.
I have added a changelog entry describing my changes.

codecov · 2020-09-15T08:50:08Z

Codecov Report

Merging #904 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #904   +/-   ##
=======================================
  Coverage   95.39%   95.39%           
=======================================
  Files         100      100           
  Lines        3626     3626           
=======================================
  Hits         3459     3459           
  Misses        167      167

Flag	Coverage Δ
#ios	`95.43% <ø> (ø)`
#macos	`97.09% <ø> (ø)`
#tvos	`57.09% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
Sources/SwifterSwift/UIKit/UIImageExtensions.swift	`83.06% <ø> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00d8f3e...0039a22. Read the comment docs.

SwifterSwiftBot · 2020-09-15T08:53:38Z

	1 Warning
⚠️	Consider adding tests for new extensions or updating existing tests for a modified SwifterSwift extension

	1 Message
📖	Thank you for submitting a pull request to SwifterSwift. The team will review your submission as soon as possible.

Generated by 🚫 Danger

guykogus

Please add a CHANGELOG entry and perhaps update the tests

* fix UIImage rotated(by:) lose origin scale * add change log

unknown-undefined · 2020-09-21T02:55:13Z

CHANGELOG entry is added, all tests is OK and passed.

Sources/SwifterSwift/UIKit/UIImageExtensions.swift

Co-authored-by: Luciano Almeida <[email protected]>

add parameter doc Co-authored-by: Luciano Almeida <[email protected]>

LucianoPAlmeida

LGTM! Thanks :)

guykogus

I personally strongly dislike the /*opaque*/ comments, but 🤷‍♂️

LucianoPAlmeida · 2020-09-21T21:22:17Z

I personally strongly dislike the /*opaque*/ comments, but 🤷‍♂️

Ahh feel free to request changes, I personally find useful for literals and use a lot at work with C++ because functions don't have labels there, so we use this pattern to make it easier to read at call site what the parameter means e.g. p->function(param, /*argument=*/nullptr) ...
But feel free to revert ... it's not that important

@Yanpanpan it is good to go can you just revert this so we can merge? :)

guykogus

Ok fine, let's get rid of it...

guykogus · 2020-09-21T22:20:12Z

Sources/SwifterSwift/UIKit/UIImageExtensions.swift

@@ -139,7 +139,7 @@ public extension UIImage {
                                     width: destRect.width.rounded(),
                                     height: destRect.height.rounded())

-        UIGraphicsBeginImageContext(roundedDestRect.size)
+        UIGraphicsBeginImageContextWithOptions(roundedDestRect.size, /*opaque=*/false, scale)


Suggested change

UIGraphicsBeginImageContextWithOptions(roundedDestRect.size, /*opaque=*/false, scale)

UIGraphicsBeginImageContextWithOptions(roundedDestRect.size, false, scale)

guykogus · 2020-09-21T22:20:23Z

Sources/SwifterSwift/UIKit/UIImageExtensions.swift

@@ -169,7 +169,7 @@ public extension UIImage {
                                     width: destRect.width.rounded(),
                                     height: destRect.height.rounded())

-        UIGraphicsBeginImageContext(roundedDestRect.size)
+        UIGraphicsBeginImageContextWithOptions(roundedDestRect.size, /*opaque=*/false, scale)


Suggested change

UIGraphicsBeginImageContextWithOptions(roundedDestRect.size, /*opaque=*/false, scale)

UIGraphicsBeginImageContextWithOptions(roundedDestRect.size, false, scale)

This reverts commit e8bae5e.

This reverts commit e4cc7ed.

unknown-undefined · 2020-09-22T02:10:11Z

I personally strongly dislike the /*opaque*/ comments, but 🤷‍♂️

Ahh feel free to request changes, I personally find useful for literals and use a lot at work with C++ because functions don't have labels there, so we use this pattern to make it easier to read at call site what the parameter means e.g. p->function(param, /*argument=*/nullptr) ...
But feel free to revert ... it's not that important

@Yanpanpan it is good to go can you just revert this so we can merge? :)

I personally think removing /*opaque*/ looks more SwifterSwift. Thanks everyone. Revert is done.

LucianoPAlmeida

Thank you!

SD10 · 2020-09-22T07:53:04Z

Thank you for contributing to SwifterSwift! I've invited you to join the SwifterSwift GitHub organization - no pressure to accept! If you'd like more information on what that means, check out our contributing guidelines. Feel free to reach out if you have any questions! 😃

fix bug: Rotated UIImage lose origin scale and blured.

25c221c

guykogus requested changes Sep 17, 2020

View reviewed changes

guykogus and others added 2 commits September 17, 2020 10:54

Merge branch 'master' into fix_UIImage_rotated_bug

b8adfa0

fix bug: UIImage rotated(by:) #904

376ae86

* fix UIImage rotated(by:) lose origin scale * add change log

unknown-undefined requested a review from guykogus September 21, 2020 06:02

Merge branch 'master' into fix_UIImage_rotated_bug

ca2c9bf

LucianoPAlmeida reviewed Sep 21, 2020

View reviewed changes

Sources/SwifterSwift/UIKit/UIImageExtensions.swift Show resolved Hide resolved

LucianoPAlmeida reviewed Sep 21, 2020

View reviewed changes

Sources/SwifterSwift/UIKit/UIImageExtensions.swift Show resolved Hide resolved

unknown-undefined and others added 2 commits September 21, 2020 16:38

Update Sources/SwifterSwift/UIKit/UIImageExtensions.swift

e8bae5e

Co-authored-by: Luciano Almeida <[email protected]>

Update Sources/SwifterSwift/UIKit/UIImageExtensions.swift

e4cc7ed

add parameter doc Co-authored-by: Luciano Almeida <[email protected]>

LucianoPAlmeida previously approved these changes Sep 21, 2020

View reviewed changes

guykogus mentioned this pull request Sep 21, 2020

UIImage.rotated(by:) should use UIGraphicsBeginImageContextWithOptions rather than UIGraphicsBeginImageContext #840

Closed

guykogus approved these changes Sep 21, 2020

View reviewed changes

guykogus requested changes Sep 21, 2020

View reviewed changes

unknown-undefined added 2 commits September 22, 2020 10:09

Revert "Update Sources/SwifterSwift/UIKit/UIImageExtensions.swift"

d0b87a0

This reverts commit e8bae5e.

Revert "Update Sources/SwifterSwift/UIKit/UIImageExtensions.swift "

0039a22

This reverts commit e4cc7ed.

unknown-undefined dismissed LucianoPAlmeida’s stale review via 0039a22 September 22, 2020 02:09

LucianoPAlmeida approved these changes Sep 22, 2020

View reviewed changes

guykogus approved these changes Sep 22, 2020

View reviewed changes

guykogus merged commit 7838df7 into SwifterSwift:master Sep 22, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix bug: Rotated UIImage lose origin scale and blured. #904

fix bug: Rotated UIImage lose origin scale and blured. #904

unknown-undefined commented Sep 15, 2020

codecov bot commented Sep 15, 2020 •

edited

Loading

SwifterSwiftBot commented Sep 15, 2020 •

edited

Loading

guykogus left a comment

unknown-undefined commented Sep 21, 2020

LucianoPAlmeida left a comment

guykogus left a comment

LucianoPAlmeida commented Sep 21, 2020

guykogus left a comment

guykogus Sep 21, 2020

guykogus Sep 21, 2020

unknown-undefined commented Sep 22, 2020

LucianoPAlmeida left a comment

SD10 commented Sep 22, 2020

	UIGraphicsBeginImageContextWithOptions(roundedDestRect.size, /opaque=/false, scale)
	UIGraphicsBeginImageContextWithOptions(roundedDestRect.size, false, scale)

fix bug: Rotated UIImage lose origin scale and blured. #904

fix bug: Rotated UIImage lose origin scale and blured. #904

Conversation

unknown-undefined commented Sep 15, 2020

Checklist

codecov bot commented Sep 15, 2020 • edited Loading

Codecov Report

SwifterSwiftBot commented Sep 15, 2020 • edited Loading

guykogus left a comment

Choose a reason for hiding this comment

unknown-undefined commented Sep 21, 2020

LucianoPAlmeida left a comment

Choose a reason for hiding this comment

guykogus left a comment

Choose a reason for hiding this comment

LucianoPAlmeida commented Sep 21, 2020

guykogus left a comment

Choose a reason for hiding this comment

guykogus Sep 21, 2020

Choose a reason for hiding this comment

guykogus Sep 21, 2020

Choose a reason for hiding this comment

unknown-undefined commented Sep 22, 2020

LucianoPAlmeida left a comment

Choose a reason for hiding this comment

SD10 commented Sep 22, 2020

codecov bot commented Sep 15, 2020 •

edited

Loading

SwifterSwiftBot commented Sep 15, 2020 •

edited

Loading