refactor: add validation to storage, repo and session blueprints #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 9, 2024
Panaetius
force-pushed
the
refactor/304-add-validation-to-repos-sessions-storage
branch
2 times, most recently
from
bc1ad6a
to
8a9ed32
Compare
olevski
previously approved these changes
Aug 12, 2024
Panaetius
force-pushed
the
refactor/304-add-ulid-sqlalchemy
branch
from
c42f324
to
cd53826
Compare
Panaetius
force-pushed
the
refactor/304-add-validation-to-repos-sessions-storage
branch
from
8a9ed32
to
286e4b2
Compare
Panaetius
force-pushed
the
refactor/304-add-ulid-sqlalchemy
branch
from
cd53826
to
9640498
Compare
Panaetius
force-pushed
the
refactor/304-add-validation-to-repos-sessions-storage
branch
from
286e4b2
to
e11a1b8
Compare
Panaetius
force-pushed
the
refactor/304-add-ulid-sqlalchemy
branch
from
9640498
to
a4ee522
Compare
Panaetius
force-pushed
the
refactor/304-add-validation-to-repos-sessions-storage
branch
2 times, most recently
from
21da488
to
6995153
Compare
|
This change is part of the following stack: Change managed by git-spice. |
Panaetius
force-pushed
the
refactor/304-add-ulid-sqlalchemy
branch
from
97219e4
to
dab2f8e
Compare
Panaetius
force-pushed
the
refactor/304-add-validation-to-repos-sessions-storage
branch
2 times, most recently
from
8c8068c
to
8dbfc73
Compare
Panaetius
force-pushed
the
refactor/304-add-ulid-sqlalchemy
branch
from
7177da0
to
b6a2fcc
Compare
Panaetius
force-pushed
the
refactor/304-add-validation-to-repos-sessions-storage
branch
2 times, most recently
from
def8f59
to
41c601e
Compare
Panaetius
force-pushed
the
refactor/304-add-ulid-sqlalchemy
branch
from
b6a2fcc
to
f49e146
Compare
Panaetius
force-pushed
the
refactor/304-add-validation-to-repos-sessions-storage
branch
3 times, most recently
from
c1a81e8
to
558fe97
Compare
Panaetius
force-pushed
the
refactor/304-add-ulid-sqlalchemy
branch
from
f49e146
to
90b6fc8
Compare
Panaetius
force-pushed
the
refactor/304-add-validation-to-repos-sessions-storage
branch
from
558fe97
to
5ca8b63
Compare
olevski
approved these changes
Sep 27, 2024
olevski
force-pushed
the
release-amaltheas-migration
branch
from
7fcfa17
to
be5272b
Compare
olevski
force-pushed
the
release-amaltheas-migration
branch
3 times, most recently
from
fd2e56c
to
df3bb88
Compare
Panaetius
force-pushed
the
refactor/304-add-validation-to-repos-sessions-storage
branch
from
8a1e546
to
f122db0
Compare
Panaetius
had a problem deploying
to
renku-ci-ds-347
GitHub Actions
Failure
Panaetius
deleted the
refactor/304-add-validation-to-repos-sessions-storage
branch
|
Tearing down the temporary RenkuLab deplyoment for this PR. |
olevski
pushed a commit
that referenced
this pull request
Oct 8, 2024
olevski
pushed a commit
that referenced
this pull request
Oct 22, 2024
olevski
pushed a commit
that referenced
this pull request
Oct 28, 2024
olevski
pushed a commit
that referenced
this pull request
Oct 28, 2024
olevski
pushed a commit
that referenced
this pull request
Oct 30, 2024
olevski
pushed a commit
that referenced
this pull request
Oct 31, 2024
olevski
pushed a commit
that referenced
this pull request
Nov 1, 2024
olevski
pushed a commit
that referenced
this pull request
Nov 4, 2024
olevski
pushed a commit
that referenced
this pull request
Nov 6, 2024
olevski
pushed a commit
that referenced
this pull request
Nov 8, 2024
olevski
pushed a commit
that referenced
this pull request
Nov 11, 2024
olevski
pushed a commit
that referenced
this pull request
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to change the ULID regex for the schemathesis tests. a 26 char ulid can theoretically store 130 bits, but ulid are limited to 128 bit. so they can't start with
8or higher (that would be a too high timestamp). As per the specEDIT: A breaking a change that requires changes on the UI. -> SwissDataScienceCenter/renku-ui#3299
/deploy renku=feat-jupyter-free-sessions amalthea-sessions=main renku-notebooks=feat-add-amalthea-session-cache renku-gateway=master renku-ui=andrea/use-data-service-sessions-2.0 extra-values=amalthea-sessions.deployCrd=false #notest