Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update script.js #3945

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

mst-rajatmishra
Copy link

improved debouncing of the scroll event, modularized functionality, and more efficient night mode and search handling.

Copy link
Collaborator

@ibrahimdevop21 ibrahimdevop21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mst-rajatmishra ,

Thanks so much for your contribution! I really appreciate the effort you’ve put into it.

Here's what I understood from your changes:

  • You've improved the debouncing of the scroll event, making it more efficient and reducing unnecessary triggers.
  • Modularized key functionality, which will help maintain and extend the code in the future.
  • Streamlined the night mode toggle to handle card updates more efficiently and avoid lags.
  • Enhanced the search functionality by adding a delay for better performance and more consistent highlighting of search terms.

However, since I'm not as experienced in this specific area to confidently give final approval, I'll have someone from the team with more expertise review it shortly.

Thanks for your patience, and feel free to reach out if you have any questions in the meantime!

Best,
@ibrahimdevop21

@mst-rajatmishra
Copy link
Author

Hi @ibrahimdevop21 ,

Thank you for the kind words and feedback! I'm glad to hear that the changes are helpful. I appreciate you having someone with more expertise review the work. If they have any questions or need further clarification, I'm more than happy to assist.

Looking forward to hearing back!

Best,
@mst-rajatmishra

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants