Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CartBlamerListener breaks jwt login #657

Closed
mamazu opened this issue Jun 29, 2020 · 0 comments
Closed

CartBlamerListener breaks jwt login #657

mamazu opened this issue Jun 29, 2020 · 0 comments
Assignees
@mamazu
Labels
Bug

Comments

@mamazu
Copy link
Member

mamazu commented Jun 29, 2020

Steps to reproduce

  • Setup sylius
  • Install shopapi plugin
  • Run bin/console lexik:jwt:generate-token sylius --user-class Sylius\\Component\\Core\\Model\\AdminUser

Then it will run the CartBlamer which requires there to be a request in the request stack which is not set up in the console.
@mamazu mamazu added the Bug label Jun 29, 2020
@mamazu mamazu self-assigned this Jun 29, 2020
mamazu added a commit to mamazu/ShopApiPlugin that referenced this issue Jun 29, 2020
@mamazu
Fixes Sylius#657
3ea6eb7
@mamazu mamazu closed this as completed in 33640a1 Jul 1, 2020
mamazu added a commit that referenced this issue Jul 1, 2020
@mamazu
bug #658 Fixes #657 (mamazu)
3ace127 
This PR was merged into the 1.0-dev branch.

Discussion
----------

If the login was from the console we don't want to assign a cart to the user object.

Commits
-------

33640a1 Fixes #657
3ea83ef Adding tests for cart blamer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mamazu mamazu

Labels
Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mamazu