Fix doctrine migrations #318
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: The commit 060d162 updated the composer dependencies and introduced some breakages. The composer.lock was using the doctrine/doctrine-migrations-bundle:v1.3.2 and the doctrine/migrations:v1.8.1 versions. The doctrine/migrations package major upgrade to the v2.0.0 version changed the autoload namespace of AbstractMigration class and started to use the new PHP 7.0 return type declarations feature. Fix #317
|
Hello @lemuelroberto and thank you for this fix! Two more things should be done to make it work:
Good luck! :) |
|
Hi @Zales0123 for your support. I'll work this through soon :) |
|
Thank you @lemuelroberto for your work, there was a lot of other fixes that were required to make build green, I've included your changes in #322. Thank you! |
windragon0910
added a commit
to windragon0910/symfony_ecom_framework
that referenced
this pull request
Oct 25, 2023
This PR was merged into the 1.3-dev branch. Discussion ---------- It contains changes from Sylius/Sylius-Standard#318 Commits ------- 5b5282c3522cf7e53d1875320798cdd9661e5c45 Fix doctrine migrations 0603090c4a8687cded4e036c89ea424abcd5599f Add missing migration and remove unused use statements 2a1bce1fc2656c8a6f96902020a905c3f20a021f Use SymfonyExtension 2.0 fbc4abdcd450c0ad70ff1649690991d429780b91 After rebase fixes 40e154759bcdfb0a8446d4d24f5d805b5f258bd0 PR review fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #317 issue.
Context:
The commit 060d162 updated the composer
dependencies and introduced some breakages.
The composer.lock was using the doctrine/doctrine-migrations-bundle:v1.3.2
and the doctrine/migrations:v1.8.1 versions.
The doctrine/migrations package major upgrade to the v2.0.0 version changed
the autoload namespace of AbstractMigration class and started to use the new
PHP 7.0 return type declarations feature.