Overriding plugin templates in themes tests #10094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartoszpietrzak1994
approved these changes
Jan 14, 2019
pamil
reviewed
Jan 14, 2019
pamil
approved these changes
Jan 14, 2019
Zales0123
force-pushed
the
1.2-plugin-templates-in-themes-tests
branch
from
eece89f
to
f7ba8a5
Compare
Zales0123
force-pushed
the
1.2-plugin-templates-in-themes-tests
branch
from
f7ba8a5
to
ba78f11
Compare
|
Thank you, Mateusz! 🎉 |
Merged
pamil
added a commit
that referenced
this pull request
Jan 15, 2019
This PR was merged into the 1.3 branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | 1.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | related to #10094 | License | MIT Is there any possibility to avoid duplicated routing files in `test/` and `test_cached/`? ⚖️ Commits ------- 5713402 Fix composer.json b004cc5 Fix ThemeBundle + plugins tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can imagine this PR can be a little bit controversial 😄 but I hope it can be a nice step forward to make
ThemeBundlemore reliable.As there is no easy way to test overriding plugin templates inside
ThemeBundleitself (as it would require us to use trait fromCoreBundle), I thought it would be nice to implement such a "test plugin" for Behat tests. It's maybe not the most elegant way, but it tests themes connected with plugins quite well and I don't see having a test plugin only for scenarios a bad thing, as we already have test themes or test bundles in our test suite.I was also thinking, that maybe such a test should be implemented on our https://github.com/Sylius/PluginSkeleton, but I really consider overriding plugins template as a
ThemeBundlefeature, rather than plugins... possibility 🚀