Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Doc] Fix service name for custom taxation calculator #9611

Merged
merged 1 commit into from
Jul 25, 2018
Merged

[Doc] Fix service name for custom taxation calculator #9611

merged 1 commit into from
Jul 25, 2018

Conversation

dannyvw
Copy link
Contributor

@dannyvw dannyvw commented Jul 23, 2018

Q A
Branch? 1.0
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets fixes #9604
License MIT

Zales0123
Zales0123 approved these changes Jul 25, 2018
View reviewed changes
Copy link
Member

@Zales0123 Zales0123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

However base branch needs to be changed to 1.1 as it's the lowest supported right now :)

@Zales0123 Zales0123 changed the base branch from 1.0 to 1.1 July 25, 2018 10:43
@Zales0123 Zales0123 added the Documentation Documentation related issues and PRs - requests, fixes, proposals. label Jul 25, 2018
@Zales0123 Zales0123 merged commit df2a878 into Sylius:1.1 Jul 25, 2018
@Zales0123
Copy link
Member

Thank you Danny!

@dannyvw dannyvw deleted the feature/doc-custom-calculators branch July 25, 2018 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lchrusciel lchrusciel lchrusciel approved these changes

@Zales0123 Zales0123 Zales0123 approved these changes

@CoderMaggie CoderMaggie Awaiting requested review from CoderMaggie

Assignees
No one assigned
Labels
Documentation Documentation related issues and PRs - requests, fixes, proposals.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dannyvw @Zales0123 @lchrusciel