Added account verification option to fixture parser #9616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vntw
reviewed
Jul 26, 2018
| @@ -40,7 +40,7 @@ protected function configureResourceNode(ArrayNodeDefinition $resourceNode): voi | |||
| ->scalarNode('tax_calculation_strategy')->end() | |||
| ->booleanNode('enabled')->end() | |||
| ->booleanNode('skipping_shipping_step_allowed')->end() | |||
| ->booleanNode('skipping_payment_step_allowed')->end() | |||
There was a problem hiding this comment.
Removing skipping_payment_step_allowed looks wrong, did you do it by mistake?
lchrusciel
approved these changes
Jul 26, 2018
pamil
suggested changes
Jul 26, 2018
| @@ -41,6 +41,7 @@ protected function configureResourceNode(ArrayNodeDefinition $resourceNode): voi | |||
| ->booleanNode('enabled')->end() | |||
| ->booleanNode('skipping_shipping_step_allowed')->end() | |||
| ->booleanNode('skipping_payment_step_allowed')->end() | |||
| ->booleanNode('account_verification_required')->defaultTrue()->end() | |||
There was a problem hiding this comment.
We handle the default values in OptionsResolver in the example factory, could you remove ->defaultTrue() here and customise configureOptions method in ChannelExampleFactory?
pamil
approved these changes
Jul 26, 2018
Zales0123
approved these changes
Jul 26, 2018
|
Thank you, @mamazu! 🎉 |
|
Well, we need it for our shop, but you are welcome. 😆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this pull request the switch for account verification in the channel entity is now configurable in the Sylius fixtures.