Init Deserialize provider #780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loic425
force-pushed
the
feature/deserialize-provider
branch
from
0e0d1fa
to
8ac206b
Compare
diimpp
reviewed
Nov 10, 2023
diimpp
reviewed
Nov 15, 2023
Comment on lines
32
to
33
| /** @var HttpOperationInitiatorInterface|ObjectProphecy */ | ||
| private $operationInitiator; |
There was a problem hiding this comment.
Suggested change
| /** @var HttpOperationInitiatorInterface|ObjectProphecy */ | |
| private $operationInitiator; | |
| private HttpOperationInitiatorInterface|ObjectProphecy $operationInitiator; |
There was a problem hiding this comment.
yeah it was on previous PR, and this is changed
Comment on lines
35
to
36
| /** @var SerializerInterface|ObjectProphecy */ | ||
| private $serializer; |
There was a problem hiding this comment.
Suggested change
| /** @var SerializerInterface|ObjectProphecy */ | |
| private $serializer; | |
| private SerializerInterface|ObjectProphecy $serializer; |
There was a problem hiding this comment.
yeah it was on previous PR, and this is changed
Comment on lines
38
to
39
| /** @var DeserializeListener */ | ||
| private $deserializableListener; |
There was a problem hiding this comment.
Suggested change
| /** @var DeserializeListener */ | |
| private $deserializableListener; | |
| private DeserializeListener $deserializableListener; |
loic425
force-pushed
the
feature/deserialize-provider
branch
from
2f4a9ed
to
cf6b133
Compare
loic425
force-pushed
the
feature/deserialize-provider
branch
from
cf6b133
to
031c58a
Compare
loic425
force-pushed
the
feature/deserialize-provider
branch
from
031c58a
to
ed0300e
Compare
Co-authored-by: Dmitri Perunov <[email protected]>
diimpp
approved these changes
Nov 20, 2023
lchrusciel
approved these changes
Nov 20, 2023
|
Thank you, @loic425! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs #781 first
Not used and no DI for now, cause we need the ReadProvider first.