Phpunit tests for Symfony read listener #782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loic425
force-pushed
the
phpspec2phpunit/symfony/event-listener-read-listener
branch
from
4ab1e45
to
b545768
Compare
Merged
loic425
force-pushed
the
phpspec2phpunit/symfony/event-listener-read-listener
branch
from
b545768
to
f98f14b
Compare
diimpp
approved these changes
Nov 20, 2023
|
|
||
| $this->operationInitiator->initializeOperation($request)->willReturn($operation); | ||
|
|
||
| $request->attributes = $attributes; |
There was a problem hiding this comment.
Is it possible or makes sense to prophesize attributes directly to $request->attributes?
There was a problem hiding this comment.
nope, we cannot do that.
There was a problem hiding this comment.
We also did like that on the old spec file.
loic425
force-pushed
the
phpspec2phpunit/symfony/event-listener-read-listener
branch
from
f98f14b
to
3163781
Compare
lchrusciel
added a commit
that referenced
this pull request
Nov 21, 2023
This PR was merged into the 1.11 branch. Discussion ---------- | Q | A | --------------- | ----- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Related tickets | | License | MIT Based on #782 Commits ------- 45d5b25 Phpunit tests for Symfony read listener 3163781 Improve test of read listener 345475e Init read provider
loic425
deleted the
phpspec2phpunit/symfony/event-listener-read-listener
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #780