Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flash from event on processor #680

Conversation

loic425
Copy link
Member

@loic425 loic425 commented Mar 30, 2023

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Related tickets fixes #677
License MIT

@loic425 loic425 requested a review from a team as a code owner March 30, 2023 13:37
@loic425 loic425 force-pushed the feature/add-flash-from-event-on-processor branch from 64b73b0 to e17bc37 Compare April 4, 2023 12:45
@loic425 loic425 force-pushed the feature/add-flash-from-event-on-processor branch from e17bc37 to 10184f1 Compare May 31, 2023 14:59
@loic425 loic425 force-pushed the feature/add-flash-from-event-on-processor branch from 10184f1 to 27277bc Compare June 12, 2023 20:57
@loic425 loic425 force-pushed the feature/add-flash-from-event-on-processor branch from 27277bc to 602c260 Compare June 20, 2023 12:50
@loic425 loic425 force-pushed the feature/add-flash-from-event-on-processor branch from 602c260 to 9aa7fcc Compare June 20, 2023 12:53
@loic425 loic425 force-pushed the poc-new-resource-metadata branch 2 times, most recently from b5a7698 to 5ad1d7d Compare June 20, 2023 13:59
@lchrusciel lchrusciel merged commit c82db7b into Sylius:poc-new-resource-metadata Jun 21, 2023
@lchrusciel
Copy link
Member

Thank you, @loic425!

@loic425 loic425 deleted the feature/add-flash-from-event-on-processor branch June 21, 2023 20:53
lchrusciel added a commit that referenced this pull request Jun 22, 2023
This PR was merged into the 1.11 branch.

Discussion
----------

| Q               | A
| --------------- | -----
| Bug fix?        | no
| New feature?    |/yes
| BC breaks?      | no
| Deprecations?   | 
| Related tickets | 
| License         | MIT

It's already approved by @lchrusciel.
Duplicated from #680 but merged in the wrong branch.

Commits
-------

2ff863b Add flash from event on processor
133a142 Fix Flash helper
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants