Move some namespaces on new Metadata #774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
loic425
commented
Nov 6, 2023
loic425
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | |
| License | MIT |
loic425
changed the title
loic425
force-pushed
the
move-component-namespace/new-metadata
branch
2 times, most recently
from
97aa866
to
9ba4eb4
Compare
oallain
approved these changes
Nov 6, 2023
Yes, these classes have been introduced in 1.11 so, they don't need any bc-layer. |
diimpp
requested changes
Nov 7, 2023
src/Component/Symfony/Routing/Factory/OperationRouteFactoryInterface.php
Show resolved
Hide resolved
diimpp
reviewed
Nov 7, 2023
src/Component/spec/Symfony/Routing/Factory/CollectionOperationRoutePathFactorySpec.php
Outdated
Show resolved
Hide resolved
src/Component/spec/Symfony/Routing/Factory/CreateOperationRoutePathFactorySpec.php
Outdated
Show resolved
Hide resolved
src/Component/spec/Symfony/Routing/Factory/DeleteOperationRoutePathFactorySpec.php
Outdated
Show resolved
Hide resolved
src/Component/spec/Symfony/Routing/Factory/DeleteOperationRoutePathFactorySpec.php
Outdated
Show resolved
Hide resolved
src/Component/spec/Symfony/Routing/Factory/UpdateOperationRoutePathFactorySpec.php
Outdated
Show resolved
Hide resolved
src/Component/spec/Symfony/Routing/Factory/UpdateOperationRoutePathFactorySpec.php
Outdated
Show resolved
Hide resolved
loic425
force-pushed
the
move-component-namespace/new-metadata
branch
from
741361a
to
818d8f3
Compare
diimpp
approved these changes
Nov 7, 2023
lchrusciel
approved these changes
Nov 8, 2023
loic425
force-pushed
the
move-component-namespace/new-metadata
branch
from
c769b5d
to
91e7768
Compare
|
Thank you, @loic425! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.