Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move some namespaces on repository #820

Merged
merged 12 commits into from
Jan 19, 2024
2 changes: 1 addition & 1 deletion docs/configuration.md
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ namespace App\Repository;

use App\Entity\Book;
use Doctrine\Bundle\DoctrineBundle\Repository\ServiceEntityRepository;
use Sylius\Component\Resource\Repository\RepositoryInterface;
use Sylius\Resource\Doctrine\Persistence\RepositoryInterface;

class BookRepository extends ServiceEntityRepository implements RepositoryInterface
{
Expand Down
2 changes: 1 addition & 1 deletion docs/configure_your_operations.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,9 @@ There are some basic CRUD operations and more.
```php
namespace App\Entity;

use Sylius\Resource\Model\ResourceInterface;
use Sylius\Resource\Metadata\AsResource;
use Sylius\Resource\Metadata\Index;
use Sylius\Resource\Model\ResourceInterface;

#[AsResource]
#[Index]
Expand Down
10 changes: 5 additions & 5 deletions docs/configure_your_resource.md
diimpp marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@ It will configure your entity as a Sylius resource.
```php
namespace App\Entity;

use Sylius\Resource\Model\ResourceInterface;
use Sylius\Resource\Metadata\AsResource;
use Sylius\Resource\Model\ResourceInterface;

#[AsResource]
class Book implements ResourceInterface
Expand Down Expand Up @@ -78,8 +78,8 @@ It defines the resource name.
```php
namespace App\Entity;

use Sylius\Resource\Model\ResourceInterface;
use Sylius\Resource\Metadata\AsResource;
use Sylius\Resource\Model\ResourceInterface;

#[AsResource(name: 'cart')]
class Order implements ResourceInterface
Expand Down Expand Up @@ -107,8 +107,8 @@ It defines the resource plural name.
```php
namespace App\Entity;

use Sylius\Resource\Model\ResourceInterface;
use Sylius\Resource\Metadata\AsResource;
use Sylius\Resource\Model\ResourceInterface;

#[AsResource(pluralName: 'library')]
class Book implements ResourceInterface
Expand All @@ -124,7 +124,7 @@ As an example, on an `index` operation these Twig variables will be available:
| Name | Type |
|-------------------|-------------------------------------------|
| resources | Pagerfanta\Pagerfanta |
| library | APagerfanta\Pagerfanta |
| library | Pagerfanta\Pagerfanta |
| operation | Sylius\Resource\Metadata\Index |
| resource_metadata | Sylius\Resource\Metadata\ResourceMetadata |
| app | Symfony\Bridge\Twig\AppVariable |
Expand All @@ -136,8 +136,8 @@ It defines the simple vars that you can use on your templates.
```php
namespace App\Entity;

use Sylius\Resource\Model\ResourceInterface;
use Sylius\Resource\Metadata\AsResource;
use Sylius\Resource\Model\ResourceInterface;

#[AsResource(vars: ['header' => 'Library', 'subheader' => 'Managing your library'])]
class Book implements ResourceInterface
Expand Down
2 changes: 1 addition & 1 deletion docs/create_new_resource.md
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ use App\Entity\Book;
use Doctrine\Bundle\DoctrineBundle\Repository\ServiceEntityRepository;
use Doctrine\Persistence\ManagerRegistry;
use Sylius\Bundle\ResourceBundle\Doctrine\ORM\ResourceRepositoryTrait;
use Sylius\Component\Resource\Repository\RepositoryInterface;
use Sylius\Resource\Doctrine\Persistence\RepositoryInterface;

/**
* @extends ServiceEntityRepository<Book>
Expand Down
4 changes: 2 additions & 2 deletions docs/redirect.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,10 @@ declare(strict_types=1);

namespace App\Entity;

use Sylius\Resource\Model\ResourceInterface;
use Sylius\Resource\Metadata\AsResource;
use Sylius\Resource\Metadata\Create;
use Sylius\Resource\Metadata\Update;
use Sylius\Resource\Model\ResourceInterface;

#[AsResource]
#[Create(redirectToRoute: 'app_book_update')]
Expand Down Expand Up @@ -65,9 +65,9 @@ declare(strict_types=1);

namespace App\Entity;

use Sylius\Resource\Model\ResourceInterface;
use Sylius\Resource\Metadata\AsResource;
use Sylius\Resource\Metadata\Create;
use Sylius\Resource\Model\ResourceInterface;

#[AsResource]
#[Create(
Expand Down
7 changes: 4 additions & 3 deletions docs/resource_factories.md
Original file line number Diff line number Diff line change
Expand Up @@ -95,9 +95,9 @@ declare(strict_types=1);

namespace App\Entity\Book;

use Sylius\Resource\Model\ResourceInterface;
use Sylius\Resource\Metadata\AsResource;
use Sylius\Resource\Metadata\Create;
use Sylius\Resource\Model\ResourceInterface;

#[AsResource]
#[Create(
Expand Down Expand Up @@ -129,7 +129,7 @@ declare(strict_types=1);
namespace App\Factory;

use App\Entity\Book;
use Sylius\Component\Resource\Repository\RepositoryInterface;
use Sylius\Resource\Doctrine\Persistence\RepositoryInterface;
use Sylius\Resource\Factory\FactoryInterface;

final class BookFactory implements FactoryInterface
Expand Down Expand Up @@ -240,12 +240,13 @@ namespace App\Entity\Book;
use App\Factory\BookFactory;
use Sylius\Resource\Metadata\AsResource;
use Sylius\Resource\Metadata\Create;
use Sylius\Resource\Model\ResourceInterface

#[AsResource]
#[Create(
factory: [BookFactory::class, 'create'],
)]
class Book implements \Sylius\Resource\Model\ResourceInterface
class Book implements ResourceInterface
{
}
```
Expand Down
2 changes: 1 addition & 1 deletion docs/responders.md
Original file line number Diff line number Diff line change
Expand Up @@ -66,9 +66,9 @@ Use it on your operation.

namespace App\Entity;

use Sylius\Resource\Model\ResourceInterface;
use Sylius\Resource\Metadata\AsResource;
use Sylius\Resource\Metadata\Show;
use Sylius\Resource\Model\ResourceInterface;

#[AsResource]
#[Show(
Expand Down
5 changes: 3 additions & 2 deletions phpstan.neon
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ parameters:
- %currentWorkingDirectory%/src/Component/Generator/*
- %currentWorkingDirectory%/src/Component/Model/*
- %currentWorkingDirectory%/src/Component/Reflection/ClassReflection.php
- %currentWorkingDirectory%/src/Component/Repository/*
- %currentWorkingDirectory%/src/Component/spec/*
- %currentWorkingDirectory%/src/Component/Storage/*
- %currentWorkingDirectory%/src/Component/Tests/*
Expand Down Expand Up @@ -57,8 +58,8 @@ parameters:
- '/Method Sylius\\Resource\\Model\\ResourceInterface::getId\(\) has no return typehint specified./'
- '/Method Sylius\\Resource\\Model\\TimestampableInterface::setCreatedAt\(\) has no return typehint specified./'
- '/Method Sylius\\Resource\\Model\\TimestampableInterface::setUpdatedAt\(\) has no return typehint specified./'
- '/Method Sylius\\Component\\Resource\\Repository\\InMemoryRepository::findBy\(\) has parameter \$limit with no type specified./'
- '/Method Sylius\\Component\\Resource\\Repository\\InMemoryRepository::findBy\(\) has parameter \$offset with no type specified./'
- '/Method Sylius\\Resource\\Doctrine\\Persistence\\InMemoryRepository::findBy\(\) has parameter \$limit with no type specified./'
- '/Method Sylius\\Resource\\Doctrine\\Persistence\\InMemoryRepository::findBy\(\) has parameter \$offset with no type specified./'
- '/Method Symfony\\Component\\Routing\\RouteCollection::add\(\) invoked with 3 parameters, 2 required\./'
- '/Method Symfony\\Contracts\\EventDispatcher\\EventDispatcherInterface::dispatch\(\) invoked with 2 parameters, 1 required\./'
- '/Parameter \#1 \$currentPage of method Pagerfanta\\Pagerfanta<mixed>::setCurrentPage\(\) expects int<1, max>, int given\./'
Expand Down
16 changes: 9 additions & 7 deletions psalm.xml
Original file line number Diff line number Diff line change
Expand Up @@ -88,26 +88,26 @@

<InvalidReturnStatement>
<errorLevel type="suppress">
<file name="src/Component/Repository/InMemoryRepository.php" />
<file name="src/Component/src/Doctrine/Persistence/InMemoryRepository.php" />
<file name="src/Bundle/Grid/Parser/OptionsParser.php" />
</errorLevel>
</InvalidReturnStatement>

<InvalidReturnType>
<errorLevel type="suppress">
<file name="src/Component/Repository/InMemoryRepository.php" />
<file name="src/Component/src/Doctrine/Persistence/InMemoryRepository.php" />
</errorLevel>
</InvalidReturnType>

<LessSpecificImplementedReturnType>
<errorLevel type="suppress">
<file name="src/Component/Repository/InMemoryRepository.php" />
<file name="src/Component/src/Doctrine/Persistence/InMemoryRepository.php" />
</errorLevel>
</LessSpecificImplementedReturnType>

<LessSpecificReturnStatement>
<errorLevel type="suppress">
<file name="src/Component/Repository/InMemoryRepository.php" />
<file name="src/Component/src/Doctrine/Persistence/InMemoryRepository.php" />
</errorLevel>
</LessSpecificReturnStatement>

Expand All @@ -122,7 +122,7 @@
<MissingParamType>
<errorLevel type="suppress">
<file name="src/Bundle/Routing/ResourceLoader.php" />
<file name="src/Component/Repository/InMemoryRepository.php" />
<file name="src/Component/src/Doctrine/Persistence/InMemoryRepository.php" />
</errorLevel>
</MissingParamType>

Expand Down Expand Up @@ -194,10 +194,11 @@
<errorLevel type="suppress">
<directory name="src/Component/Annotation" />
<directory name="src/Component/Factory" />
<directory name="src/Component/Metadata" />
<directory name="src/Component/Generator" />
<directory name="src/Component/Metadata" />
<directory name="src/Component/Model" />
<directory name="src/Component/Reflection" />
<directory name="src/Component/Repository" />
<directory name="src/Component/Storage" />
<file name="src/Bundle/Event/ResourceControllerEvent.php" />
</errorLevel>
Expand All @@ -223,9 +224,10 @@
<UnrecognizedStatement>
<errorLevel type="suppress">
<directory name="src/Component/Factory" />
<directory name="src/Component/Metadata" />
<directory name="src/Component/Generator" />
<directory name="src/Component/Metadata" />
<directory name="src/Component/Model" />
<directory name="src/Component/Repository" />
<directory name="src/Component/Storage" />
</errorLevel>
</UnrecognizedStatement>
Expand Down
2 changes: 1 addition & 1 deletion src/Bundle/Controller/ResourceController.php
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@
use Sylius\Bundle\ResourceBundle\Event\ResourceControllerEvent;
use Sylius\Component\Resource\Exception\DeleteHandlingException;
use Sylius\Component\Resource\Exception\UpdateHandlingException;
use Sylius\Component\Resource\Repository\RepositoryInterface;
use Sylius\Component\Resource\ResourceActions;
use Sylius\Resource\Doctrine\Persistence\RepositoryInterface;
use Sylius\Resource\Factory\FactoryInterface;
use Sylius\Resource\Metadata\MetadataInterface;
use Sylius\Resource\Model\ResourceInterface;
Expand Down
2 changes: 1 addition & 1 deletion src/Bundle/Controller/ResourceDeleteHandler.php
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

namespace Sylius\Bundle\ResourceBundle\Controller;

use Sylius\Component\Resource\Repository\RepositoryInterface;
use Sylius\Resource\Doctrine\Persistence\RepositoryInterface;
use Sylius\Resource\Model\ResourceInterface;

final class ResourceDeleteHandler implements ResourceDeleteHandlerInterface
Expand Down
2 changes: 1 addition & 1 deletion src/Bundle/Controller/ResourceDeleteHandlerInterface.php
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

namespace Sylius\Bundle\ResourceBundle\Controller;

use Sylius\Component\Resource\Repository\RepositoryInterface;
use Sylius\Resource\Doctrine\Persistence\RepositoryInterface;
use Sylius\Resource\Model\ResourceInterface;

interface ResourceDeleteHandlerInterface
Expand Down
2 changes: 1 addition & 1 deletion src/Bundle/Controller/ResourcesCollectionProvider.php
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
use Hateoas\Representation\Factory\PagerfantaFactory;
use Pagerfanta\Pagerfanta;
use Sylius\Bundle\ResourceBundle\Grid\View\ResourceGridView;
use Sylius\Component\Resource\Repository\RepositoryInterface;
use Sylius\Resource\Doctrine\Persistence\RepositoryInterface;

final class ResourcesCollectionProvider implements ResourcesCollectionProviderInterface
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

namespace Sylius\Bundle\ResourceBundle\Controller;

use Sylius\Component\Resource\Repository\RepositoryInterface;
use Sylius\Resource\Doctrine\Persistence\RepositoryInterface;

interface ResourcesCollectionProviderInterface
{
Expand Down
2 changes: 1 addition & 1 deletion src/Bundle/Controller/ResourcesResolver.php
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

namespace Sylius\Bundle\ResourceBundle\Controller;

use Sylius\Component\Resource\Repository\RepositoryInterface;
use Sylius\Resource\Doctrine\Persistence\RepositoryInterface;

final class ResourcesResolver implements ResourcesResolverInterface
{
Expand Down
2 changes: 1 addition & 1 deletion src/Bundle/Controller/ResourcesResolverInterface.php
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

namespace Sylius\Bundle\ResourceBundle\Controller;

use Sylius\Component\Resource\Repository\RepositoryInterface;
use Sylius\Resource\Doctrine\Persistence\RepositoryInterface;

interface ResourcesResolverInterface
{
Expand Down
2 changes: 1 addition & 1 deletion src/Bundle/Controller/SingleResourceProvider.php
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

namespace Sylius\Bundle\ResourceBundle\Controller;

use Sylius\Component\Resource\Repository\RepositoryInterface;
use Sylius\Resource\Doctrine\Persistence\RepositoryInterface;
use Sylius\Resource\Model\ResourceInterface;

final class SingleResourceProvider implements SingleResourceProviderInterface
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

namespace Sylius\Bundle\ResourceBundle\Controller;

use Sylius\Component\Resource\Repository\RepositoryInterface;
use Sylius\Resource\Doctrine\Persistence\RepositoryInterface;
use Sylius\Resource\Model\ResourceInterface;

interface SingleResourceProviderInterface
Expand Down
2 changes: 1 addition & 1 deletion src/Bundle/Doctrine/ODM/MongoDB/DocumentRepository.php
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
use Doctrine\ODM\MongoDB\DocumentRepository as BaseDocumentRepository;
use Pagerfanta\Doctrine\MongoDBODM\QueryAdapter;
use Pagerfanta\Pagerfanta;
use Sylius\Component\Resource\Repository\RepositoryInterface;
use Sylius\Resource\Doctrine\Persistence\RepositoryInterface;
use Sylius\Resource\Model\ResourceInterface;

trigger_deprecation('sylius/resource-bundle', '1.3', 'The "%s" class is deprecated. Doctrine MongoDB and PHPCR support will no longer be supported in 2.0.', DocumentRepository::class);
Expand Down
2 changes: 1 addition & 1 deletion src/Bundle/Doctrine/ODM/PHPCR/DocumentRepository.php
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
use Doctrine\ODM\PHPCR\Query\Builder\QueryBuilder;
use Pagerfanta\Doctrine\PHPCRODM\QueryAdapter;
use Pagerfanta\Pagerfanta;
use Sylius\Component\Resource\Repository\RepositoryInterface;
use Sylius\Resource\Doctrine\Persistence\RepositoryInterface;
use Sylius\Resource\Model\ResourceInterface;

trigger_deprecation('sylius/resource-bundle', '1.3', 'The "%s" class is deprecated. Doctrine MongoDB and PHPCR support will no longer be supported in 2.0.', DocumentRepository::class);
Expand Down
2 changes: 1 addition & 1 deletion src/Bundle/Doctrine/ORM/EntityRepository.php
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
namespace Sylius\Bundle\ResourceBundle\Doctrine\ORM;

use Doctrine\ORM\EntityRepository as BaseEntityRepository;
use Sylius\Component\Resource\Repository\RepositoryInterface;
use Sylius\Resource\Doctrine\Persistence\RepositoryInterface;

/** @psalm-suppress DeprecatedInterface */
class EntityRepository extends BaseEntityRepository implements RepositoryInterface
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

namespace Sylius\Bundle\ResourceBundle\Form\DataTransformer;

use Sylius\Component\Resource\Repository\RepositoryInterface;
use Sylius\Resource\Doctrine\Persistence\RepositoryInterface;
use Sylius\Resource\Model\ResourceInterface;
use Symfony\Component\Form\DataTransformerInterface;
use Symfony\Component\Form\Exception\TransformationFailedException;
Expand Down
2 changes: 1 addition & 1 deletion src/Bundle/Form/Type/ResourceAutocompleteChoiceType.php
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
use Sylius\Bundle\ResourceBundle\Form\DataTransformer\RecursiveTransformer;
use Sylius\Bundle\ResourceBundle\Form\DataTransformer\ResourceToIdentifierTransformer;
use Sylius\Component\Registry\ServiceRegistryInterface;
use Sylius\Component\Resource\Repository\RepositoryInterface;
use Sylius\Resource\Doctrine\Persistence\RepositoryInterface;
use Symfony\Component\Form\AbstractType;
use Symfony\Component\Form\Extension\Core\Type\HiddenType;
use Symfony\Component\Form\FormBuilderInterface;
Expand Down
2 changes: 1 addition & 1 deletion src/Bundle/Form/Type/ResourceToIdentifierType.php
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
namespace Sylius\Bundle\ResourceBundle\Form\Type;

use Sylius\Bundle\ResourceBundle\Form\DataTransformer\ResourceToIdentifierTransformer;
use Sylius\Component\Resource\Repository\RepositoryInterface;
use Sylius\Resource\Doctrine\Persistence\RepositoryInterface;
use Sylius\Resource\Metadata\MetadataInterface;
use Symfony\Bridge\Doctrine\Form\Type\EntityType;
use Symfony\Component\Form\AbstractType;
Expand Down
2 changes: 1 addition & 1 deletion src/Bundle/Grid/Controller/ResourcesResolver.php
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
use Sylius\Bundle\ResourceBundle\Grid\View\ResourceGridViewFactoryInterface;
use Sylius\Component\Grid\Parameters;
use Sylius\Component\Grid\Provider\GridProviderInterface;
use Sylius\Component\Resource\Repository\RepositoryInterface;
use Sylius\Resource\Doctrine\Persistence\RepositoryInterface;

final class ResourcesResolver implements ResourcesResolverInterface
{
Expand Down
2 changes: 1 addition & 1 deletion src/Bundle/spec/Controller/ResourceControllerSpec.php
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,8 @@
use Sylius\Bundle\ResourceBundle\Controller\ViewHandlerInterface;
use Sylius\Bundle\ResourceBundle\Event\ResourceControllerEvent;
use Sylius\Component\Resource\Exception\DeleteHandlingException;
use Sylius\Component\Resource\Repository\RepositoryInterface;
use Sylius\Component\Resource\ResourceActions;
use Sylius\Resource\Doctrine\Persistence\RepositoryInterface;
use Sylius\Resource\Factory\FactoryInterface;
use Sylius\Resource\Metadata\MetadataInterface;
use Sylius\Resource\Model\ResourceInterface;
Expand Down
2 changes: 1 addition & 1 deletion src/Bundle/spec/Controller/ResourceDeleteHandlerSpec.php
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@

use PhpSpec\ObjectBehavior;
use Sylius\Bundle\ResourceBundle\Controller\ResourceDeleteHandlerInterface;
use Sylius\Component\Resource\Repository\RepositoryInterface;
use Sylius\Resource\Doctrine\Persistence\RepositoryInterface;
use Sylius\Resource\Model\ResourceInterface;

final class ResourceDeleteHandlerSpec extends ObjectBehavior
Expand Down
Loading
Loading