-
Notifications
You must be signed in to change notification settings - Fork 216
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix persistent rooms condition (#492)
- Loading branch information
Showing
1 changed file
with
2 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
566f90b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any idea why the Windows workflow seems to be failing?
566f90b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ImportTaste I've not confirmed it, but my suspicion is that the build system changed to be one which couldn't handle null files. This would mean that it is now broken by https://github.com/Syncplay/syncplay/blob/master/.github/workflows/build.yml#L45 which creates a zero-byte syncplay.ini file for Syncplay portable. I've not tested it, but I hope that changing syncplay.ini from $NULL to a newline would fix it.