Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mpv.net store version path detection to syncplay #494

Closed
soredake opened this issue Dec 22, 2021 · 3 comments
Closed

Add mpv.net store version path detection to syncplay #494

soredake opened this issue Dec 22, 2021 · 3 comments

Comments

@soredake
Copy link
Contributor

soredake commented Dec 22, 2021

Describe the bug
Syncplay doesn't detect mpv.net from store.

To Reproduce
Steps to reproduce the behavior:

  1. Install https://www.microsoft.com/en-us/p/mpvnet/9n64sqztb3lm
  2. Run syncplay
  3. mpv.net from store is not detected.

Expected behavior
Syncplay detected $env:LOCALAPPDATA\Microsoft\WindowsApps\mpvnet.exe as mpv.net binary

Screenshots
If applicable, add screenshots to help explain your problem.

Version and platform:

  • OS: Windows 11 Pro
  • Syncplay version and build type: Syncplay 1.6.9

Additional context
Add any other context about the problem here.

@Et0h
Copy link
Contributor

Et0h commented Jan 2, 2022

Syncplay was looking for mpv.net in the following locations:

  • 'c:\program files\mpv.net\mpvnet.exe'
  • 'c:\program Files (x86)\mpv.net\mpvnet.exe'

Thanks to your suggestion I will now add '%LOCALAPPDATA%\Microsoft\WindowsApps\mpvnet.exe' to the list.

@Et0h
Copy link
Contributor

Et0h commented Jan 2, 2022

@soredake The mpvnet.exe file in the WindowsApp seems to be some sort of weird dummy file which Python doesn't detect as existing, so I had to hack it to actually look for mpvnet.com instead but then run the .exe version.

When you have time please test it out at and let me know if it works properly for you - you can give either the portable or installer versions of Syncplay a try:

@soredake
Copy link
Contributor Author

soredake commented Jan 2, 2022

@Et0h thanks, it detects it now.

@Et0h Et0h closed this as completed Jan 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants