Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shared playlist is empty for everyone after reconnection until something is added/removed in playlist #567

Closed
soredake opened this issue Dec 3, 2022 · 6 comments

Comments

@soredake
Copy link
Contributor

soredake commented Dec 3, 2022

Describe the bug
When you're alone in the room and you added something to shared playlist, after reconnecting to server shared playlist will be empty for everyone until you change shared playlist (add/remove something).

To Reproduce
Steps to reproduce the behavior:

  1. Start syncplay, connect to room (you need to be alone in the room) and add something to playlist.
  2. Disconnect from network.
  3. After reconnection you will still see playlist items, but anyone who joins will see empty playlist until something is added/changed in playlist.

Expected behavior
Playlist should not be empty for everyone who will join up after the one who updated playlist reconnected to server.

Screenshots
If applicable, add screenshots to help explain your problem.

Version and platform:

  • OS: Windows 11 Pro
  • Syncplay version and build type: Syncplay 1.7.0 beta 1
  • Media player and version: latest mpv

Additional context
I've reproduced this in windows 11 <-> windows 11 with Syncplay 1.7.0 beta 1, with windows 11 <-> fedora kde 37 in vm with Syncplay 1.6.9 and with windows 11 <-> https://github.com/Reddnek/syncplay-android version 0.10.1

@soredake soredake changed the title Shared playlist is empty for everyone until Shared playlist is empty for everyone after reconnection until something is added/removed in playlist Dec 3, 2022
@Et0h
Copy link
Contributor

Et0h commented Feb 23, 2023

Thanks for the clarity of your bug report. It took me a bit of time to figure out a reasonable way to fix the issue by restoring the playlist when it is appropriate to do so (and not when it isn't), but I think I've got a working solution now.

@soredake Could you please test my proposed fix and and confirm that it resolves the issue: https://github.com/Syncplay/syncplay/actions/runs/4256136168

@soredake
Copy link
Contributor Author

soredake commented Feb 24, 2023

@Et0h when i tested this build yesterday your fix is worked and playlist is restored after reconnection, but after retesting now I've again see empty playlist in vm and syncplay-android, don't know why it's worked yesterday.

@Et0h
Copy link
Contributor

Et0h commented Feb 24, 2023

@soredake Thanks for the testing. Hopefully this version should work so please give it a test: https://github.com/Syncplay/syncplay/actions/runs/4263298780

When testing, it is important to disconnect for at least 13 seconds to ensure that any 'ghost' version of the original connection have been timed out by the server.

My test methodology is to use the public servers and temporarily disable and re-enable my internet connection.

@soredake
Copy link
Contributor Author

@Et0h disconnected for 5/20 seconds - can see playlist in vm/mobile app, thanks!

Et0h added a commit that referenced this issue Feb 28, 2023
* Restore server-side playlist on reconnect (#567)

* Restore server-side playlist on reconnect (v2)
@Et0h
Copy link
Contributor

Et0h commented Mar 19, 2023

This tweak is now included in Syncplay 1.7.0 RC 1: https://syncplay.pl/syncplay-1-7-0-release-candidate-1/

@soredake
Copy link
Contributor Author

soredake commented Apr 8, 2023

Thank you again for fixing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants