-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shared playlist is empty for everyone after reconnection until something is added/removed in playlist #567
Comments
Thanks for the clarity of your bug report. It took me a bit of time to figure out a reasonable way to fix the issue by restoring the playlist when it is appropriate to do so (and not when it isn't), but I think I've got a working solution now. @soredake Could you please test my proposed fix and and confirm that it resolves the issue: https://github.com/Syncplay/syncplay/actions/runs/4256136168 |
@Et0h when i tested this build yesterday your fix is worked and playlist is restored after reconnection, but after retesting now I've again see empty playlist in vm and syncplay-android, don't know why it's worked yesterday. |
@soredake Thanks for the testing. Hopefully this version should work so please give it a test: https://github.com/Syncplay/syncplay/actions/runs/4263298780 When testing, it is important to disconnect for at least 13 seconds to ensure that any 'ghost' version of the original connection have been timed out by the server. My test methodology is to use the public servers and temporarily disable and re-enable my internet connection. |
@Et0h disconnected for 5/20 seconds - can see playlist in vm/mobile app, thanks! |
This tweak is now included in Syncplay 1.7.0 RC 1: https://syncplay.pl/syncplay-1-7-0-release-candidate-1/ |
Thank you again for fixing this! |
Describe the bug
When you're alone in the room and you added something to shared playlist, after reconnecting to server shared playlist will be empty for everyone until you change shared playlist (add/remove something).
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Playlist should not be empty for everyone who will join up after the one who updated playlist reconnected to server.
Screenshots
If applicable, add screenshots to help explain your problem.
Version and platform:
Additional context
I've reproduced this in windows 11 <-> windows 11 with Syncplay 1.7.0 beta 1, with windows 11 <-> fedora kde 37 in vm with Syncplay 1.6.9 and with windows 11 <-> https://github.com/Reddnek/syncplay-android version 0.10.1
The text was updated successfully, but these errors were encountered: