-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wildcard matching in trusted domains #587
Comments
@name-snrl & @Tremolo4 : I've created a pull request which hopefully adds the feature requested here, but it uses regex so it's worth giving it lots of testing to make sure it doesn't break the trust logic in some weird way. Please give it a try via https://github.com/Syncplay/syncplay/actions/runs/4237707314 and let me know if it works via the pull request discussion. |
The change has now been made. All that is left is to consider what, if any, changes want to be made to the client documentation at https://syncplay.pl/guide/client/ |
I've now updated the client guide, so this issue is being closed. |
Wildcard matching doesn't work. I tried
trusteddomains = ['youtube.com', 'youtu.be', 'eu.ngrok.io']
andtrusteddomains = ['youtube.com', 'youtu.be', '.eu.ngrok.io']
.Details here: Originally posted by @name-snrl in #437 (comment)
The text was updated successfully, but these errors were encountered: