Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wildcard matching in trusted domains #587

Closed
name-snrl opened this issue Feb 21, 2023 · 3 comments
Closed

wildcard matching in trusted domains #587

name-snrl opened this issue Feb 21, 2023 · 3 comments

Comments

@name-snrl
Copy link

Wildcard matching doesn't work. I tried trusteddomains = ['youtube.com', 'youtu.be', 'eu.ngrok.io'] and trusteddomains = ['youtube.com', 'youtu.be', '.eu.ngrok.io'].

Details here: Originally posted by @name-snrl in #437 (comment)

@Et0h
Copy link
Contributor

Et0h commented Feb 21, 2023

@name-snrl & @Tremolo4 : I've created a pull request which hopefully adds the feature requested here, but it uses regex so it's worth giving it lots of testing to make sure it doesn't break the trust logic in some weird way. Please give it a try via https://github.com/Syncplay/syncplay/actions/runs/4237707314 and let me know if it works via the pull request discussion.

@Et0h
Copy link
Contributor

Et0h commented Mar 11, 2023

The change has now been made. All that is left is to consider what, if any, changes want to be made to the client documentation at https://syncplay.pl/guide/client/

@Et0h
Copy link
Contributor

Et0h commented Apr 8, 2023

I've now updated the client guide, so this issue is being closed.

@Et0h Et0h closed this as completed Apr 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants