-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transition to PySide2 and Qt 5.x #185
Conversation
…ds to private servers)
…suggested by xNinjaKittyx)
I just added three commits to fix issue #184, add a Qt 5 license notice, and fix a typo in all the messages. |
Side note: I tried to embed the PySide2 official wheels on Windows, but they are not releasing them for x86 and, as far as I know, there are no wheels for py2exe_py2 for win_amd64. So, for the moment, we are stuck with conda packages. We could attempt this replacement after migrating the codebase to Python 3 and PyInstaller. EDIT: I just found this in the Qt for Python Development Notes of this week
So, maybe there is still hope to have official wheels suitable for the current packaging of Syncplay for Windows. |
Updated after merging PR #188. |
Qt for Python was released today, as a technical preview (v5.11.0 TP), with some caveats:
In summary, this is the status of this PR for the three platforms:
|
For the moment, we decided to stick with PySide 1.x on Windows, and migrate to PySide2 v5.11.0 on the other two platforms. The PR has just been updated accordingly. |
@albertosottile Am I correct that the primary change of this PR is to move the macOS default build from PySide1 to a Syncplay-compatible version of PySide2 and that after this PR Linux users should continue to be able to use either PySide1 or PySide2? |
Yes, perfect recap. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just tested on Windows 10 and it doesn't seem to break anything.
This PR contains the migration of Syncplay to PySide2, following the discussion of issue #152.
While it is true that PySide2 (side note: the official name is now Qt for Python) has not been officially released yet, the binding is stable enough for beta testing its behavior with Syncplay. Furthermore, in view of the upcoming dismissal of Python 2, we need to accelerate the transition to Qt 5. Ideally, once this PR is merged, we will release a beta 1.5.4 version to allow extensive tests of Syncplay on Qt 5 on all the platforms.
Despite the large number of commits indicated by GitHub, only the packaging files are changed in this PR, while the Syncplay code is actually the same as in current master, thanks to Qt.py (with the exception of a few tabs in ui/ConfigurationGetter.py).
The code in this PR updates the packaging CI systems as detailed hereafter:
Incidentally, this PR solves issue #149.
Known limitations: