Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bundle libgthread-2.0.so.0 into AppImage #432

Merged
merged 1 commit into from
Jul 21, 2021
Merged

Bundle libgthread-2.0.so.0 into AppImage #432

merged 1 commit into from
Jul 21, 2021

Conversation

teohhanhui
Copy link
Contributor

@teohhanhui teohhanhui commented Jun 19, 2021 •
edited
Loading

Fixes #431

@teohhanhui teohhanhui force-pushed the fix/appimage-missing-deps branch 2 times, most recently from 7c7559e to 7f5a0a5 Compare June 19, 2021 21:21
@teohhanhui teohhanhui changed the title Install libglib2.0-0 package before AppImage build Bundle libgthread-2.0.so.0 into AppImage Jun 19, 2021
@teohhanhui
Copy link
Contributor Author

https://github.com/teohhanhui/syncplay/runs/2866441348?check_suite_focus=true#step:4:206

@daniel-123
Copy link
Contributor

I've tried to add libxcb-util in the same way you added libgthread and it fixed the issue in #380, so I assume this is a valid solution. I'll make PR to fix #380 once this PR is merged.

@albertosottile
Copy link
Member

albertosottile commented Jul 21, 2021 •
edited
Loading

LGTM. @teohhanhui Could you rebase on latest master? This will now trigger the Actions workflow on this pull request. Thanks.

@daniel-123 daniel-123 merged commit acc8a05 into Syncplay:master Jul 21, 2021
@teohhanhui teohhanhui deleted the fix/appimage-missing-deps branch July 23, 2021 16:04
@frei0 frei0 mentioned this pull request Oct 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albertosottile albertosottile Awaiting requested review from albertosottile

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[AppImage] Missing libgthread-2.0.so.0
3 participants
@teohhanhui @daniel-123 @albertosottile