Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows dark mode #483

Merged
merged 14 commits into from
Dec 9, 2021
Merged

Windows dark mode #483

merged 14 commits into from
Dec 9, 2021

Conversation

Et0h
Copy link
Contributor

@Et0h Et0h commented Nov 9, 2021

No description provided.

@Et0h Et0h closed this Nov 9, 2021
@Et0h Et0h reopened this Nov 13, 2021
@Et0h
Copy link
Contributor Author

Et0h commented Nov 13, 2021

@sxiii @CalMaciborka @Zefferis @0lhi

Please test using dark mode support for Windows:

Light/dark mode should follow your system settings for Windows 10 Anniversary users and above.

Thanks to @albertosottile for his work on the dark mode detector which we use for this feature.

@Et0h
Copy link
Contributor Author

Et0h commented Nov 16, 2021

See #480 for a discussion on the title bar.

@TeamDman
Copy link

TeamDman commented Nov 25, 2021

Looks great to me!
Only comment is that the titlebar changes to white when unfocused, not sure if there's an easy solution to that which doesn't involve custom window controls like discord/spotify.

image
image
image

The closest maybe-non-custom thing I can think of would be the new Outlook's dark mode

image

@Et0h
Copy link
Contributor Author

Et0h commented Nov 25, 2021

@TeamDman This seems to relate to how Windows behaves rather than being a Syncplay-specific issue.

I just looked it up and following the advice at https://www.reddit.com/r/Windows10/comments/93e2yp/black_accent_color_in_windows_10/ worked for me. However, the advice is a bit old so I had to tweak what I did a bit: I had to set the 'Windows colours' under 'Colours' to a dark grey and also enable 'Title bars and window borders' under 'Show the accent colour on the following surfaces'. As usual, if you mess with your registry then you do so at your own risk.

@Et0h Et0h merged commit d60efab into master Dec 9, 2021
@albertosottile albertosottile deleted the windows_dark_mode branch November 27, 2022 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants