Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't pass empty model to QCompleter #647

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Don't pass empty model to QCompleter #647

merged 1 commit into from
Nov 13, 2023

Conversation

luk1337
Copy link
Contributor

@luk1337 luk1337 commented Nov 10, 2023

It's empty by default.

@Et0h Et0h self-requested a review November 13, 2023 18:18
Et0h
Et0h approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@Et0h Et0h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested this change and the changes don't seem to break anything on Windows 10.

@daniel-123
Copy link
Contributor

Tested on Debian Linux with no issues observed.

@Et0h Et0h merged commit 14c82a6 into Syncplay:master Nov 13, 2023
3 checks passed
@luk1337 luk1337 deleted the luk/completer branch November 13, 2023 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Et0h Et0h Et0h approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luk1337 @daniel-123 @Et0h