-
-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SSR support for use_web_notification
and use_service_worker
#46
Comments
What do you have in mind for |
Nothing really. I have no idea 😂 I'm not sure if it even makes sense to anything on the server for this. But if we can make sure that it doesn't panic on the server that's already better than now. |
Hmmm, how about this:
Also, |
As far as I understand this, the function is more about installing and using a concrete service worker which has to be done on the frontend anyway. So I think if we can just make sure that you can run this function without having to put it inside a I'm not convinced that all this extra work on the server would be worth it. Or am I missing something? |
Hmmm, fair enough. I was thinking of also providing data if the service worker is supported, so that SSR can be rendered differently based on whether it is supported or not, but I think this should work too. What should be returned in the server side in the version you'd mentioned? |
I think this should work: {
registration: ServiceWorkerRegistrationError::NeverQueried,
installing: false,
waiting: false,
active: false,
check_for_update: || (),
skip_waiting: || (),
} |
use_web_notification
use_service_worker
The text was updated successfully, but these errors were encountered: