-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"CellList's distinctness invariant" when selecting frames #3971
Comments
Repro'd with Ctrl+Shift+A keyboard shortcut but not my stacktrace FWIW
|
I was able to reproduce this even when my cursor wasn't on frame 0. It happens basically anytime I try to Original:
Simplify 1: same, but insert only 500 frames, markers on frames 200 and 400, don't seek, and select frame 201. Simplify 2: same, but insert only 10 frames, markers on frames 2 and 11, don't seek, and select frame 10. I only frame-advanced for the sake of my original methodology of inserting frames, since I didn't want to insert at frame 0. |
I'm just not sure what the "correct" fix here is. The base problem is pretty simple: Some way or another an attempt is made to select a certain number of rows from the input roll, without regard for whether any of them are already selected. One way to fix this could be to just remove the Debug.Assert. We already have the logic to prevent duplicate selections and could just silently reject them. Alternatively, every time a cell is to be selected, the calling code needs to make sure that this cell isn't already selected (I did something like that in 8278b30 already). |
I believe this method was already non-atomic so this clear operation shouldn't change anything
Try that ^ |
Reopen once this inevitably happens again on some other code path. |
This is new to the dev build. It isn't present in 2.9.1.
I went through
git bisect
and it yielded 2a67cf9 unsurprisingly.Maybe this wouldn't be present if I built BizHawk in release configuration, but I didn't test that.
Repro
Tools > TAStudio
)Ctrl+A
to select all framesCtrl+A
for the first time, regardless of whether it's been emulated or not.Output
This error dialog doesn't have copy pastable contents, so I'll leave getting the rest as an exercise for the reviewer.
If you Ignore, it repeats for all cells in the row and then it seems to be fine.
Host env.
The text was updated successfully, but these errors were encountered: