Lua tests #3373
Merged
Lua tests #3373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
some tests are commented out as they fail lol
YoshiRulz
reviewed
Sep 10, 2022
|
|
||
| [LuaMethod("pass_f128", "")] | ||
| public static void PassF128(decimal? o) | ||
| => Assert.IsTrue(o == (decimal?)ExpectedValue); |
There was a problem hiding this comment.
https://docs.microsoft.com/en-us/dotnet/api/system.decimal?view=netstandard-2.0
"The binary representation of a Decimal value is 128-bits consisting of a 96-bit integer number, and a 32-bit set of flags representing things such as the sign and scaling factor used to specify what portion of it is a decimal fraction."
Different significand/exponent width compared to binary128 but it adds up to 128 bits in the end.
EDIT: Also decimal uses a 10 exponent instead of a 2 exponent for some reason, thanks Microsoft?
YoshiRulz
reviewed
Sep 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re: #3361 (comment)