Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi script drawing #3775

Closed
wants to merge 15 commits into from
Closed

Multi script drawing #3775

wants to merge 15 commits into from

Commits on Sep 19, 2023

  1. Create IToolManager, as part of moving LuaLibraries to BizHawk.Client…

    ….Common (to support testing).
    SuuperW committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    ac91285 View commit details
    Browse the repository at this point in the history
  2. Move ApiManager to BizHawk.Client.Common, as part of moving LuaLibrar…

    …ies to BizHawk.Client.Common (to support testing).
    SuuperW committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    2582894 View commit details
    Browse the repository at this point in the history
  3. Rename file. (Next commit will rename class and create new file/class…

    … with the old filename.)
    SuuperW committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    53b2d1d View commit details
    Browse the repository at this point in the history
  4. Move handling of loading EmuHawk lua librarys from LuaLibrariesBase t…

    …o LuaLibraries, as part of moving LuaLibrariesBase to BizHawk.Client.Common (to support testing).
    
    Remove params that can instead be obtained from mainForm (instead of creating private variables to hold them for reference in code that was moved outside of the constructor). Also remove them from Restart method for consistency in how ApiManager.RestartLua is called.
    SuuperW committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    1623a0f View commit details
    Browse the repository at this point in the history
  5. Remove FormsLuaLibrary reference in LuaLibrariesBase and move LuaLibr…

    …ariesBase to BizHawk.Client.Common (to support testing).
    SuuperW committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    d215201 View commit details
    Browse the repository at this point in the history
  6. Move two methods from LuaConsole to ILuaLibraries because they make m…

    …ore sense there. (They had no need of a reference to a LuaConsole.)
    
    This also supports testing by removing the need to use a LuaConsole in tests.
    SuuperW committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    7b1417a View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    1bb5f9e View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2023

  1. Update GuiApi so that TestDrawingWithTwoScripts passes. This fixes th…

    …e bug where if two lua scripts draw stuff on the same frame only one script's drawings are visible.
    
    Replaces a bunch of obscure ThisIsTheLuaHack and locking/unlocking code with a simple pair of methods.
    SuuperW committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    0c8ce93 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    594a025 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2023

  1. swap order of parameters to Assert.AreEqual, so they match parameter …

    …names (expected, actual)
    SuuperW committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    bc7decf View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2023

  1. Configuration menu
    Copy the full SHA
    30b3819 View commit details
    Browse the repository at this point in the history
  2. move some stuff and use DisplayManagerBase instead of DisplayManager,…

    … in preparation for testing external APIs
    SuuperW committed Oct 8, 2023
    Configuration menu
    Copy the full SHA
    ae76497 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2023

  1. Move most of ToolManager's functionality to new ToolManagerBase, to s…

    …upport testing external tools
    SuuperW committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    74e210e View commit details
    Browse the repository at this point in the history
  2. Refactor to make loading external tools simpler by not requiring pass…

    …ing around a load callback method.
    
    Add TestExternalToolCanUseApi (passes)
    SuuperW committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    6c1cb1e View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2023

  1. This addresses the regression from commit 0c8ce93 that made external …

    …tools unable to draw.
    
    This removes the old obsolete methods IGuiApi.DrawNew and DrawFinish (they didn't do anything; any scripts using them already didn't work).
    SuuperW committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    8bd025d View commit details
    Browse the repository at this point in the history