-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ArgParser
rewrite
#3946
ArgParser
rewrite
#3946
Conversation
If we do this, is there a way to get rid of the |
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is probably an improvement for end-users (well, assuming you get --help
to actually display stuff on windows) and about neutral for understanding code flow (it's a complete mess still).
README.md
Outdated
@@ -199,7 +199,8 @@ tl;dr: | |||
|
|||
#### Passing command-line arguments | |||
|
|||
EmuHawk takes some command-line options which aren't well-documented; you might be able to figure them out from [the source](https://github.com/TASEmulators/BizHawk/blob/78daf4913d4c8e47d24fc14d84ca33ddef913ed4/src/BizHawk.Client.Common/ArgParser.cs). | |||
EmuHawk takes some command-line options which, starting from 2.9.2, can be listed with `--help`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't actually work on windows release builds due to the WinExe
target, so this will need some consideration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've fixed this by caveating it with "on Linux".
(The CommandLineBuilder.UseHelp(Action<HelpContext>)
overload does seem to run on-demand i.e. only when --help
is passed, if you wanted to look into that Win32 Console hack post-merge.)
Rebased, only differences are:
There are no actionable review comments left (edit: for me to do, that is; the possibility for |
I'd still like to improve the documentation further, but this is functional already.Documentation improved. If you have scripts for e.g. encoding please test them.Don't merge without checking the commit hash in
README.md
(it should be of the commit immediately before the readme change).