order firmware groups in the dialog and in the code

[vadosnaprimer]

there's some discrepancy between the 2 orders, because the GUI list relies on full names (of the groups) while in the code short names are used to add them to DB

[Morilli]

I like this. Being prompted for a firmware and then having to search through the (seemingly) unsorted list is very annoying.

[YoshiRulz]

The sort call is fine, but why are you then also sorting in the source?

[vadosnaprimer]

Because it's a nightmare to scroll through unsorted mess every time you need to add/edit something.

[YoshiRulz]

Ctrl+F?

[vadosnaprimer]

Dude seriously? You actually need it to be unsorted, and searching it by trying to remember what the short name is is absolutely the only allowed way?

[YoshiRulz]

IDRC, but it would have been nice to keep the diff clean.

[vadosnaprimer]

Why is clean diff better than clean code? It's reordered once and then it's always predictable where things are, but if the diff was the only thing that mattered, the code would always be a mess. That's a weird priority for something that's not just cosmetic but functional.

[YoshiRulz]

It clobbers the blame, and .git-blame-ignore-revs (#3349) can't see through it:

$> echo a08cb73a30f2e0877fdbd89d1f59040d3418818a >.git-blame-ignore-revs
$> git blame src/BizHawk.Emulation.Common/Database/FirmwareDatabase.cs | grep -F a08cb73a3 | wc -l
274

[vadosnaprimer]

Yeah sorry. Cleanest diff is no diff. Maybe commit description will help in such a dire situation.