POSIX cli joystick/keyboard fixes (replaces #822) #852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because the GTK frontends use GDK keysyms, not SDL ones, - the former are being stored in the config file and used by the GTK ui) - a temporary workaround was put into place 14 years ago: the loaded config values were simply being overwritten with the hardcoded defaults. this commit removes the overriding of the config, and introduces a cli frontend specific section "SDLKEYS", which is written by the GTK2 frontend upon a configuration change. it tries to convert the GDK keycodes into SDL2 ones while doing so. an alternative solution (involving less code changes) would have been to do the conversion in the cli frontend, but that would require having the gdk header available for compilation, which may not be the case if the user only wants the cli frontend. such a user could now create the config file on another machine with the GTK frontend, or simply manually take the desired values from the SDL_keycode.h header. this change is instigated by one of the changes in PR TASEmulators#822, which simply removed the workaround and kept parsing on error, which mitigated the problem for some keys, but not all.
until now, the boost key was hardcoded to 'o' even when the config said otherwise, and not treated in case of a joypad at all. when triggered with the o key, it even behaved differently than the gtk ui - the boost wasn't released together with the key, but only when pressed again, so it was more like a shortcut for "disable fps limiter". this change implements the desired outcome of the second part of PR TASEmulators#822, but without introducing more hacks and relying on magic values. closes TASEmulators#822
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.