Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EGL: use eglGetPlatformDisplay if available #865

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

thesourcehim
Copy link
Contributor

To properly use prime render offload eglGetPlatformDisplay must be used instead of eglGetDisplay. It's available in EGL 1.5, so use it if available, fallback to eglGetDisplay if not. Helps #864.

@rogerman
Copy link
Collaborator

We can assume that the EGL v1.5 headers will be available at compile time, so no need for #ifdef here. (However, we are still requiring EGL v1.4 at runtime.)

Also, your name of "attr" isn't descriptive enough, since there are other attributes in that particular function. Please rename "attr" to "displayAttr", thanks!

@thesourcehim
Copy link
Contributor Author

I guess I just try all 3 calls to obtain display handle, I don't see a way to obtain runtime EGL version before calling eglInitialize.

@rogerman rogerman merged commit 1192bf6 into TASEmulators:master Nov 13, 2024
9 checks passed
@thesourcehim thesourcehim deleted the egl_fix_attempt branch November 13, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants