Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for latest change in xrayvision #115

Merged
merged 4 commits into from
May 27, 2024

Conversation

samaloney
Copy link
Member

  • Remove no unnesary transpose from EM algorithm (due to fix in xrayvison)
  • Update imaging demo
    • Units for pixel are now arcsec/pixel
    • Flare location in array indexing (v WCS) is [stix_max.Ty, six_max.Tx]

Only to be merged after TCDSolar/xrayvision/pull/58

Copy link

codecov bot commented May 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 72.57%. Comparing base (8867c2d) to head (3ad179f).
Report is 9 commits behind head on main.

Files Patch % Lines
stixpy/imaging/em.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #115      +/-   ##
==========================================
+ Coverage   72.53%   72.57%   +0.03%     
==========================================
  Files          31       31              
  Lines        1857     1856       -1     
==========================================
  Hits         1347     1347              
+ Misses        510      509       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samaloney samaloney marked this pull request as ready for review May 27, 2024 12:03
@samaloney samaloney merged commit da09731 into TCDSolar:main May 27, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants