Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix grid transmission #146

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

samaloney
Copy link
Member

@samaloney samaloney commented Oct 15, 2024

The grid orientation angle do not have to be "flipped" by 180 deg when we compute the offset angle of the flare location relative to the slats (in arcseconds). The grid orientation angles are indeed defined as in Figure 2 of The STIX Imaging Concept paper (Massa et al., 2023).

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.56%. Comparing base (d22e0f1) to head (7deb9d7).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #146      +/-   ##
==========================================
+ Coverage   73.50%   73.56%   +0.05%     
==========================================
  Files          32       32              
  Lines        2012     2016       +4     
==========================================
+ Hits         1479     1483       +4     
  Misses        533      533              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant