Make STIXFrame work nicely with sunpy Maps #90
Conversation
|
Well after some serious rabbit holing, mostly on the plotting side finally made some progress. Still lots to fix, improve (transforms are slow due to repeated fido search and fetch calls) and look into (I don't know why the limb is behind, indicated by the dotted line, the Sun). 
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #90 +/- ##
==========================================
+ Coverage 64.25% 66.33% +2.07%
==========================================
Files 29 31 +2
Lines 1757 1821 +64
==========================================
+ Hits 1129 1208 +79
+ Misses 628 613 -15 ☔ View full report in Codecov by Sentry. |
samaloney
force-pushed
the
feat-stix-frame-wcs
branch
from
0d904cb
to
baf3a4e
Compare
| # def spatial_units(self): | ||
| # return SpatialPair(u.arcsec, u.arcsec) | ||
|
|
||
| def plot(self, **kwargs): |
There was a problem hiding this comment.
FYI for future NDCube-backed Maps, this will have to be moved into a STIXPlotter object which is attached to the STIXMap. It won't change the user-facing API though. However, no action needed on this for now.
samaloney
changed the title
Map.
samaloney
force-pushed
the
feat-stix-frame-wcs
branch
from
d735bba
to
d1545c0
Compare
Co-authored-by: DanRyanIrish <[email protected]>
samaloney
force-pushed
the
feat-stix-frame-wcs
branch
from
d1545c0
to
259a1fd
Compare
samaloney
force-pushed
the
feat-stix-frame-wcs
branch
from
259a1fd
to
74a5be4
Compare
|
Current plot 
|
* Make STIXFrame work nicely with `Map`. * Apply suggestions from code review * Fix docs and STIX map axis labels * Plot axis --------- Co-authored-by: DanRyanIrish <[email protected]>
Often want/need to do analysis in the STIX frame (really low counts) so need to support repojection and plotting etc. This PR aims to facilitate the creation of maps in the STIXImaging frame and support all the plotting, reprojections etc. Heavily based on what in sunpy coordinates.
observerandrsun