Cleanup of visibility (u,v) points definition #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
paolomassa
commented
Apr 29, 2024
paolomassa
commented
- Merged 'get_visibility_info_giordano' and 'get_visibility_info' into 'get_uv_points_data'
- Removed 'correct_phase_projection' since it is not needed with the new definition of (u,v) points
- Added 'test_visibility.py' (and removed 'test_visibility.bk')
- Updated 'imaging_demo.py' to be consistent with the new definition of (u,v) points
- Merged 'get_visibility_info_giordano' and 'get_visibility_info' into 'get_uv_points_data' - Removed 'correct_phase_projection' since it is not needed with the new definition of (u,v) points - Added 'test_visibility.py' (and removed 'test_visibility.bk') - Updated 'imaging_demo.py' to be consistent with the new definition of (u,v) points
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #98 +/- ##
==========================================
+ Coverage 62.12% 64.03% +1.90%
==========================================
Files 29 29
Lines 1769 1746 -23
==========================================
+ Hits 1099 1118 +19
+ Misses 670 628 -42 ☔ View full report in Codecov by Sentry. |
Add check for units of 'd_sep' and 'd_det' in 'get_uv_points_data'
samaloney
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.