Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Developer Website link in Contact page #12375

Closed
domlimm opened this issue Apr 14, 2023 · 3 comments · Fixed by #13157 · May be fixed by anuth212/teammates#1
Closed

Incorrect Developer Website link in Contact page #12375

domlimm opened this issue Apr 14, 2023 · 3 comments · Fixed by #13157 · May be fixed by anuth212/teammates#1
Labels
s.ToDiscuss The issue/PR is undergoing discussion/review by the core team

Comments

@domlimm
Copy link
Contributor

domlimm commented Apr 14, 2023

Environment:
V8.26.0

Steps to reproduce

https://teammatesv4.appspot.com/web/front/contact

image

Expected behaviour

Should link to https://teammates.github.io/teammates/index.html.

Actual behaviour

Links to back to TEAMMATES repository.

@samuelfangjw
Copy link
Member

This is actually intentional. Developer website was meant to be different to the developer documentation.

That being said, the fact this was raised a bug means that there is some ambiguity with the terms used. Perhaps we should consider if any other terms are better here.

@domlimm
Copy link
Contributor Author

domlimm commented Apr 14, 2023

Oh I see.. Initial thought was that clicking on the link will bring me to the developer documentation.

How about TEAMMATES GitHub? Consistent with the Blog part as TEAMMATES Blog.

Except I'm assuming developers will know GitHub. But the current Developer Website means that if anyone who is interested to join TEAMMATES, it will be someone who is looking to develop TEAMMATES?

@anuth212
Copy link
Contributor

I would like to make a PR to help fix this issue. I'll make the change to the link name so it is more clear.

@samuelfangjw samuelfangjw added the s.ToDiscuss The issue/PR is undergoing discussion/review by the core team label Apr 16, 2023
mingyuanc pushed a commit that referenced this issue Aug 7, 2024
* Update phrasing of contact page

* Update phrasing and add icon

* Add additional icons

---------

Co-authored-by: domoberzin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment