Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradle task componentTests should not stop entirely when only one task fails #12900

Closed
jayasting98 opened this issue Mar 15, 2024 · 6 comments · Fixed by #12963
Closed

Gradle task componentTests should not stop entirely when only one task fails #12900

jayasting98 opened this issue Mar 15, 2024 · 6 comments · Fixed by #12963
Labels
a-Build CI, task automation, build pipeline a-Docs User or developer docs a-Testing Testing-related traits such as efficiency, robustness, coverage c.Task Other non-user-facing works, e.g. refactoring, adding tests good first issue Easy; restricted for first-time contributors

Comments

@jayasting98
Copy link
Contributor

jayasting98 commented Mar 15, 2024

The Gradle task componentTests now depends on the two Gradle tasks unitTests, and integrationTests since #12056. These can be independent from each other, so if one fails, we should continue to execute the other (except when it fails due to the failure of a common dependency, like compilation). However, when either of them fails due to a failing test, the other one is not completed because the execution of the whole componentTests task is aborted.

To prevent this, we can run componentTests with the option --continue, just like the Gradle task lint. This probably needs to be changed in the GitHub workflows and in the documentation.

@jayasting98 jayasting98 added good first issue Easy; restricted for first-time contributors a-Docs User or developer docs a-Testing Testing-related traits such as efficiency, robustness, coverage a-Build CI, task automation, build pipeline c.Task Other non-user-facing works, e.g. refactoring, adding tests labels Mar 15, 2024
Copy link

Good First Issue - Notes for Contributors
This issue is for first-time contributors only. If you are new to TEAMMATES, feel free to submit a PR for this issue.

Please note that we allow only one good first issue per contributor. If you have already made a prior contribution to TEAMMATES, you may wish to take a look at issues with the help wanted tag instead.

We do not assign issues to contributors. If you would like to pick up this issue, do post a comment below to express your interest and check if there is anyone else who is already working on the issue. We will do our best to reply and give you the go-ahead, but if we don't, feel free to submit a PR as long as there is no one else working on it.

To get started, do read through our contributing guidelines carefully, and set up a development environment on your local machine before making a PR.

If you need any clarifications on our developer guide, or are facing issues that are not found in our troubleshooting guide, please post a message in our discussion forum.

@Hkovin
Copy link

Hkovin commented Mar 18, 2024

Hi, me and my classmate @jckras want to contribute to our first open-source project. Can we resolve this issue?

@weiquu
Copy link
Contributor

weiquu commented Mar 18, 2024

Sure @Hkovin, feel free to open a PR for this issue

@Hkovin
Copy link

Hkovin commented Mar 18, 2024

Sure @Hkovin, feel free to open a PR for this issue

Hi, my partner and I need to work on an issue with different requirements so we can no longer work on this one. Thank you though!

@emrekenar
Copy link
Contributor

Hello, can I work on this issue?

@jayasting98
Copy link
Contributor Author

@emrekenar Hi! Thank you for your interest in the project. Since there is nobody currently working on this, you are free to submit a PR for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-Build CI, task automation, build pipeline a-Docs User or developer docs a-Testing Testing-related traits such as efficiency, robustness, coverage c.Task Other non-user-facing works, e.g. refactoring, adding tests good first issue Easy; restricted for first-time contributors
Projects
None yet
4 participants