Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#12048] Migrate accounts Db #12114

Merged
merged 1 commit into from
Feb 23, 2023
Merged

[#12048] Migrate accounts Db #12114

merged 1 commit into from
Feb 23, 2023

Conversation

samuelfangjw
Copy link
Member

Part of #12048

Outline of Solution

Migrate accounts Db and clean up misc files.

@samuelfangjw samuelfangjw marked this pull request as ready for review February 22, 2023 20:39
hhdqirui
hhdqirui approved these changes Feb 23, 2023
View reviewed changes
Copy link
Member

@hhdqirui hhdqirui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hhdqirui hhdqirui added the s.FinalReview The PR is ready for final review label Feb 23, 2023
jianhandev
jianhandev approved these changes Feb 23, 2023
View reviewed changes
Copy link
Contributor

@jianhandev jianhandev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jianhandev jianhandev added s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging and removed s.FinalReview The PR is ready for final review labels Feb 23, 2023
@samuelfangjw samuelfangjw merged commit 3d4bdf3 into TEAMMATES:v9-migration Feb 23, 2023
@samuelfangjw samuelfangjw deleted the migrate-accounts branch February 23, 2023 19:44
samuelfangjw added a commit that referenced this pull request Feb 26, 2023
@samuelfangjw
[#12048] Migrate accounts db layer (#12114)
256e3cf
samuelfangjw added a commit that referenced this pull request Apr 8, 2023
@samuelfangjw
[#12048] Migrate accounts db layer (#12114)
119eee1
@wkurniawan07 wkurniawan07 added the c.Task Other non-user-facing works, e.g. refactoring, adding tests label Jan 21, 2024
@wkurniawan07 wkurniawan07 added this to the V9.0.0-beta.0 milestone Jan 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hhdqirui hhdqirui hhdqirui approved these changes

@jianhandev jianhandev jianhandev approved these changes

Assignees
No one assigned
Labels
c.Task Other non-user-facing works, e.g. refactoring, adding tests s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
None yet
Milestone
V9.0.0-beta.0
Development

Successfully merging this pull request may close these issues.
4 participants
@samuelfangjw @hhdqirui @jianhandev @wkurniawan07