[#12588] Improve test code coverage of LogsDetails #12619
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I improve test coverage from 82.35% to 100%
|
hey @siruwang, LogsDetails was assigned to @nikkixiong last week (#12588 (comment)) who has already submitted a PR here: #12618 unfortunately, this means that we have to close this PR as it is a duplicate, apologies |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12588
Outline of Solution
Improve test code coverage for LogDetails
This is the first time I've committed a PR to a formal code repository.
If there is anything I need to correct, please feel free to let me know.