Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#11843] Merge student-activity-logs into master #13041

Merged
merged 8 commits into from
Apr 18, 2024
Merged

[#11843] Merge student-activity-logs into master #13041

merged 8 commits into from
Apr 18, 2024

Conversation

dishenggg
Copy link
Contributor

Part of #11843

Outline of Solution

@dishenggg
[#11843] Create FeedbackSessionLog entity and cron job action (#12895)
17866eb 
* Create FeedbackSessionLog entity

* fix lint

* Create UpdateFeedbackSessionLogsAction

* Sort query results from logging service

* Update type of feedbackSessionLogType

* Fix naming

* Fix enum in entity

* Update filter to differentiate by session

* Add Uri Info

* Add tests

* Update test case

* Update to getOrderedFeedbackSessionLogs
@dishenggg
[#11843] Create Logic and Db layer for FeedbackSessionLogs (#12914)
ccad41b 
* Create FeedbackSessionLog entity

* fix lint

* Create UpdateFeedbackSessionLogsAction

* Sort query results from logging service

* Update type of feedbackSessionLogType

* Fix naming

* Fix enum in entity

* Update filter to differentiate by session

* Add Uri Info

* Add tests

* Update test case

* Update to getOrderedFeedbackSessionLogs

* Create skeleton

* Implement logic and db layer

* fix lint

* Update entity

* Fix tests

* Fix bugs and optimize action

* Prevent courseId from being null

* Update GCP logs to store ids

* Fix tests

* Update action to use reference

* Add some error handling

* Fix tests

* Add ids to api output
@dishenggg
[#11843] Update GetFeedbackSessionLogsAction to use SQL db (#12938)
a98630d 
* Create FeedbackSessionLog entity

* fix lint

* Create UpdateFeedbackSessionLogsAction

* Sort query results from logging service

* Update type of feedbackSessionLogType

* Fix naming

* Fix enum in entity

* Update filter to differentiate by session

* Add Uri Info

* Add tests

* Update test case

* Update to getOrderedFeedbackSessionLogs

* Create skeleton

* Implement logic and db layer

* fix lint

* Update entity

* Fix tests

* Update action to use fslDb

* Fix tests

* Update DbIT to use databundle

* Fix bugs and optimize action

* Prevent courseId from being null

* Update GCP logs to store ids

* Fix tests

* Update action to use reference

* Add some error handling

* Fix tests

* Add ids to api output

* Fix lint

* Update cron.yaml

* Tidy up code

* Update comments
@dishenggg
[#11843] Update front end for session activity logs (#12973)
8d506a1 
* Create FeedbackSessionLog entity

* fix lint

* Create UpdateFeedbackSessionLogsAction

* Sort query results from logging service

* Update type of feedbackSessionLogType

* Fix naming

* Fix enum in entity

* Update filter to differentiate by session

* Add Uri Info

* Add tests

* Update test case

* Update to getOrderedFeedbackSessionLogs

* Create skeleton

* Implement logic and db layer

* fix lint

* Update entity

* Fix tests

* Update action to use fslDb

* Fix tests

* Update DbIT to use databundle

* Fix bugs and optimize action

* Prevent courseId from being null

* Update GCP logs to store ids

* Fix tests

* Update action to use reference

* Add some error handling

* Fix tests

* Add ids to api output

* Fix lint

* Update front end

* Update cron.yaml

* Update front end

* Fix result display

* Tidy up code

* Update actions to use getUuid

* Fix formatting

* Fix bug

* Add buttons to access page

* Shift logging

* fiox bug

* fix fe tests

* Fix bug

* Fix tests

* Add IT

* remove email and fsname

* fix ts lint

* Fix status message

* Remove front end error messages

* Add assertion fortests

* Fix migrated check

* Change to use id

* Update javadoc

* Change cron job to 15 mins intervals

* fix tests

* fix fe bug

* Add delay note

* Update to use const

* Add const

* fix fe tests
@dishenggg dishenggg self-assigned this Apr 16, 2024
@dishenggg dishenggg added the s.Ongoing The PR is being worked on by the author(s) label Apr 16, 2024
@ziqing26 ziqing26 added this to the V9.0.0-beta.5 milestone Apr 17, 2024
dishenggg and others added 2 commits April 18, 2024 10:31
@dishenggg
[#11843] Fix front end bugs (#13037)
9a51e2a 
* Fix notViewedSince

* Update disclaimer

* Change disclaimer message

* Fix view result message

* Fix not viewed since message
@FergusMok
Merge branch 'master' into student-activity-logs
000e8b7
@dishenggg dishenggg marked this pull request as ready for review April 18, 2024 05:20
@dishenggg dishenggg marked this pull request as draft April 18, 2024 05:20
@FergusMok FergusMok added s.ToReview The PR is waiting for review(s) s.Ongoing The PR is being worked on by the author(s) and removed s.Ongoing The PR is being worked on by the author(s) s.ToReview The PR is waiting for review(s) labels Apr 18, 2024
@cedricongjh cedricongjh marked this pull request as ready for review April 18, 2024 07:19
cedricongjh
cedricongjh approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@cedricongjh cedricongjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cedricongjh cedricongjh merged commit 14344cf into master Apr 18, 2024
11 checks passed
@wkurniawan07 wkurniawan07 deleted the student-activity-logs branch April 19, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cedricongjh cedricongjh cedricongjh approved these changes

@FergusMok FergusMok Awaiting requested review from FergusMok

Assignees

@dishenggg dishenggg

Labels
s.Ongoing The PR is being worked on by the author(s)
Projects
None yet
Milestone
V9.0.0-beta.5
Development

Successfully merging this pull request may close these issues.
4 participants
@dishenggg @cedricongjh @FergusMok @ziqing26