Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#11878] Fix Edit #13056

Merged
merged 3 commits into from
Apr 18, 2024
Merged

[#11878] Fix Edit #13056

merged 3 commits into from
Apr 18, 2024

Conversation

domoberzin
Copy link
Contributor

Part of #11878

Outline of Solution

@domoberzin domoberzin changed the base branch from account-request-form to master April 18, 2024 11:38
@ziqing26 ziqing26 added this to the V9.0.0-beta.5 milestone Apr 18, 2024
@ziqing26 ziqing26 added the c.Bug Bug/defect report label Apr 18, 2024
@ziqing26 ziqing26 added the s.ToReview The PR is waiting for review(s) label Apr 18, 2024
jayasting98
jayasting98 approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@jayasting98 jayasting98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick response! I hope this fixes it.

@jayasting98 jayasting98 added s.FinalReview The PR is ready for final review and removed s.ToReview The PR is waiting for review(s) labels Apr 18, 2024
EuniceSim142
EuniceSim142 approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@EuniceSim142 EuniceSim142 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks 👍

@EuniceSim142 EuniceSim142 merged commit ce839ab into TEAMMATES:master Apr 18, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jayasting98 jayasting98 jayasting98 approved these changes

@EuniceSim142 EuniceSim142 EuniceSim142 approved these changes

Assignees

@domoberzin domoberzin

Labels
c.Bug Bug/defect report s.FinalReview The PR is ready for final review
Projects
None yet
Milestone
V9.0.0-beta.5
Development

Successfully merging this pull request may close these issues.
4 participants
@domoberzin @jayasting98 @EuniceSim142 @ziqing26