Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#12048] Fix seed, migration and verification script for course verification #13086

Conversation

NicolasCwy
Copy link
Contributor

@NicolasCwy NicolasCwy commented Apr 23, 2024

Part of #12048

Outline of Solution

  • Modify seed DB script to map student to a valid account
  • Fix migration script to
    • use google id instead of email to map accounts
    • allocate deadline extensions for students and instructors separately
  • Add logging to verification script

TODO

  • section chain - account and google id mismatch

@NicolasCwy NicolasCwy changed the base branch from master to v9-course-migration April 23, 2024 19:11
@NicolasCwy NicolasCwy changed the title [#12048] Fix seed, migration and verification script [#12048] Fix seed, migration and verification script for non-course verification Apr 23, 2024
@NicolasCwy NicolasCwy changed the title [#12048] Fix seed, migration and verification script for non-course verification [#12048] Fix seed, migration and verification script for course verification Apr 23, 2024
@NicolasCwy NicolasCwy marked this pull request as ready for review April 24, 2024 04:14
@NicolasCwy NicolasCwy self-assigned this Apr 24, 2024
@FergusMok FergusMok force-pushed the fix-seed-account-student-email branch from 6bc93fb to 80bcac0 Compare April 24, 2024 05:42
@marquestye
Copy link
Contributor

LGTM!

@NicolasCwy NicolasCwy merged commit 4c4a900 into TEAMMATES:v9-course-migration Apr 24, 2024
1 check passed
@NicolasCwy NicolasCwy added s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging c.Task Other non-user-facing works, e.g. refactoring, adding tests labels Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c.Task Other non-user-facing works, e.g. refactoring, adding tests s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants