Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#13144] Copy students from existing students table to new students table #13146

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

NeoHW
Copy link
Contributor

@NeoHW NeoHW commented Jul 15, 2024

Fixes #13144

Outline of Solution

Motivation and Context

For instructors who want to batch edit many students, they would have to copy and paste the whole sheet from existing students manually. The slightly clunky cell selection in the sheet would make it sometimes hard to select all students, especially if there are many students.
Therefore, I would suggest the addition of a button to auto-import existing students into the new students sheet below. This would be a QOL change and also helps when instructors want to mass-edit students.

Changes

Frontend:

  1. Added a copy students button on the enrol page and formatted it.

Backend:

  1. Created functionality to copy existing students' spreadsheets into new students' spreadsheet
  • Ran into the issue that Existing students' spreadsheet has to be expanded for logic to work
  • Another issue was the asynchronous nature of fetching data with API calls in toggleExistingStudentsPanel
  1. Modify toggleExistingStudentsPanel to take in an optional callback
  • This ensures that the data is only copied after it has been successfully loaded

Video Demo

Before:

Screen.Recording.2024-07-14.at.4.31.12.AM.mov

After:

Screen.Recording.2024-07-14.at.4.13.57.AM.mov

Copy link

Hi @NeoHW, thank you for your interest in contributing to TEAMMATES!
However, your PR does not appear to follow our contribution guidelines:

  • Title must start with the issue number the PR is fixing in square brackets, e.g. [#<issue-number>]

Please address the above before we proceed to review your PR.

@NeoHW NeoHW changed the title [13144] - Copy students from existing students table to new students table [#13144] Copy students from existing students table to new students table Jul 15, 2024
@nusoss-bot
Copy link

Folks, This PR seems to be stalling (no activities for the past 7 days). 🐌 😢
Hope someone can get it to move forward again soon...

@domoberzin domoberzin added the s.OnHold The issue/PR's validity has been put on hold pending some other event label Jul 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s.OnHold The issue/PR's validity has been put on hold pending some other event
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Copy students from existing students table to new students table
3 participants