Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing: Improve instructions and process #8844 #8979

Closed
wants to merge 0 commits into from

Conversation

tshradheya
Copy link
Member

Fixes #8844

Ongoing.

Need input on the Intellij use default reporter

Would appreciate if someone can try out the following for me and check if it works on Eclipse

1. Change the language of eclipse IDE to German.
2. Run `TimeHelperTest` and ensure it fails
3. Make the necessary changes in `gradle.properties` as made in this PR
4. After rebuilding run the same test again and ensure it passes.

Outline of Solution

  • Made default reported being true so that its standardized for IntelliJ
  • Ensured tests are not locale-dependent
  • Corrected minor problem in documentation

NOTE: Continued from #8845 as I messed up the old PR :P

@tshradheya tshradheya added the s.ToReview The PR is waiting for review(s) label Jul 20, 2018
@tshradheya tshradheya closed this Jul 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s.ToReview The PR is waiting for review(s)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant