Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversion to RNC returns a zip file #81

Closed
raffazizzi opened this issue May 14, 2024 · 5 comments · Fixed by #85
Closed

Conversion to RNC returns a zip file #81

raffazizzi opened this issue May 14, 2024 · 5 comments · Fixed by #85
Assignees

Comments

@raffazizzi
Copy link

Converting an ODD file to RNG Compact (RNC) syntax currently returns a zip file containing and RNG file and and a converted RNC file. I think it would be helpful to just return a plain text rnc file, or at least add a parameter to request it as such.

@peterstadler
Copy link
Member

I knew I have seen this before: TEIC/oxgarage#45

@anneferger anneferger self-assigned this Jun 4, 2024
@anneferger
Copy link
Contributor

anneferger commented Jun 4, 2024

I confirmed that this is exactly the same issue as the last time some years ago - and it doesn't happen on the dev version at https://teigarage2.tei-c.de (which is the same version as the main version currently), so this is again because a temp file is not deleted successfully. I will fix this in the backend and not the setup this time though, so it can't reappear again.

anneferger added a commit that referenced this issue Jun 4, 2024
anneferger added a commit to TEIC/tei-converter that referenced this issue Jun 5, 2024
peterstadler added a commit that referenced this issue Jun 5, 2024
Merge fix to #81 and dependency updates
@peterstadler peterstadler linked a pull request Jun 5, 2024 that will close this issue
@peterstadler
Copy link
Member

PR #85 addresses this and has been merged

@anneferger
Copy link
Contributor

Sorry need to reopen this one, it works on our test setup but not the original setup, will try another option

@anneferger anneferger reopened this Jun 6, 2024
@anneferger
Copy link
Contributor

Now it is actually fixed in TEIC/tei-converter@2aca34e and updated in https://teigarage.tei-c.org/. Thanks for tracking this bug again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants